-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to support TS 5.0 tsconfig extends array #6918
Comments
Not sure if there's anything we can do since it needs to be supported by https://github.com/ifiokjr/tsconfig-resolver, which doesn't seem to have recent activity. Another option is to use https://github.com/dominikg/tsconfck or https://github.com/aleclarson/vite-tsconfig-paths |
We should probably migrate to |
Blocked by dominikg/tsconfck#87, I started working on a PR for it in this fork, but since this is kinda low priority for us, I'll circle back to it later unless someone is interested in tackling it. |
@Princesseuh I would be interested to get your |
After having wasted a chunk of time on an obtuse error where I could get Nx + Astro 3 to build on my workstation and not with Dockerfile and finally tracing it to this... My issue: I extended multiple tsconfigs (!!) I haven't checked but it sort of smells to me like there might be a bit of "find an npm package for anything and everything" at play with that one where dependencies get created on a single maintainer packages that appear abandoned to save a few lines of code. Taking a peek at tsconfig-resolver's source (https://www.npmjs.com/package/tsconfig-resolver?activeTab=code), it seems like a good chunk of tsconfig-resolver effectively duplicates what Astro already has in its own codebase as a core part of its functionality plus in existing Astro packages I already see other deps on well-used libraries like fast-glob etc. Perhaps this sort of thing could be more standardized between the official plugins. https://www.reddit.com/media?url=https%3A%2F%2Fi.redd.it%2Ftfugj4n3l6ez.png |
I wish it was the case, but resolving and parsing There's a reason every framework tend to use a library / depend on TypeScript's native methods for that. If you don't implement it to the T, you risk having a different understanding of the TypeScript config in different contexts. |
What version of
astro
are you using?2.3.1
Are you using an SSR adapter? If so, which one?
None
What package manager are you using?
pnpm
What operating system are you using?
Windows
What browser are you using?
Chrome
Describe the Bug
tsconfig-resolver
does not supportextends
with array, which is a feature in TypeScript 5.0It errors with:
Link to Minimal Reproducible Example
https://stackblitz.com/edit/github-3dbiun?file=tsconfig.json
Participation
The text was updated successfully, but these errors were encountered: