-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pnpm
failure on create-astro
#7435
Conversation
🦋 Changeset detectedLatest commit: 75eedd0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
}, | ||
"devDependencies": { | ||
"@types/which-pm-runs": "^1.0.0", | ||
"arg": "^5.0.2", | ||
"astro-scripts": "workspace:*", | ||
"strip-ansi": "^7.0.1", | ||
"strip-json-comments": "^5.0.0", | ||
"which-pm-runs": "^1.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this was a dev dep... it's definitely shipped with create-astro
🤷
!preview pm-fix |
|
!preview pm-fix |
|
565f621
to
75eedd0
Compare
Changes
preferred-pm
to thewhich-pm-runs
package we already use for detecting npm versions during the "install" step (see Fixes an issue where create Astro doesn't respect custom npm registries #7326). Seemspreferred-pm
does a lot of extra work to crawl lock files andnode_modules
to find the package manager. This result can differ from the "install" step, which doesn't seem right.Testing
Docs
N/A