Fixes an issue where create Astro doesn't respect custom npm registries #7326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0ff4be4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
calebdwilliams
force-pushed
the
fix/npm-registry
branch
from
e381223 to
c8582a2
Compare
github-actions
bot
added
the
pkg: create-astro
calebdwilliams
force-pushed
the
fix/npm-registry
branch
from
c8582a2 to
b421a66
Compare
natemoo-re
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
This looks great, thanks for the PR!
Discussed on Discord and confirmed locally that these changes work both when a user has set a custom registry and when a user has no custom registry defined. Package managers properly return the default NPM registry in the latter case.
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
I'm not sure how to effectively test this fix without affecting the entire build process. Happy to accept suggestions.
Docs
This should enable Astro to behave as expected for users with custom package registries (such as large enterprises who might block the public npm registry for security or efficiency reasons).