Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefetch styles only once #5125

Merged
merged 15 commits into from
Oct 19, 2022
Merged

Prefetch styles only once #5125

merged 15 commits into from
Oct 19, 2022

Conversation

Jelenkee
Copy link
Contributor

@Jelenkee Jelenkee commented Oct 19, 2022

Changes

When multiple links where prefetched the same CSS files where fetched multiple times as well.
This PR changes the behaviour so that a CSS file is not fetched more than once.

This is the next attempt after #4557 failed

Testing

A testcase was added with two links to different pages. Both of them use the same CSS file.
The test checks if the CSS file is fetched only once

Docs

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2022

🦋 Changeset detected

Latest commit: 80ca732

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Oct 19, 2022
@Jelenkee Jelenkee changed the title Prefetch styles Prefetch styles only once Oct 19, 2022
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

@matthewp matthewp merged commit 5a674f9 into withastro:main Oct 19, 2022
@astrobot-houston astrobot-houston mentioned this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants