Prefetch CSS only once #4557
Closed
Prefetch CSS only once #4557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c52979f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
|
This seems like a totally reasonable change! I'll ping @tony-sull to take a look at this as well. Any idea why tests are failing? |
|
Sorry, I am not able to run the tests on my local machine. It's hard to write proper tests when you can only run them in Github Actions |
natemoo-re
reviewed
Sep 7, 2022
| .filter((el) => !loadedStyles.has(el.href)) | ||
| .map((el) => { | ||
| loadedStyles.add(el.href); | ||
| return fetch(el.href); |
There was a problem hiding this comment.
This promise needed to be returned, which might fix the tests! Watching CI to see.
There was a problem hiding this comment.
@Jelenkee can you try this?
|
Closing because the tests are failing. @Jelenkee If you get time, the above suggestion might fix the tests, in which case you can resubmit a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When multiple links where prefetched the same CSS files where fetched multiple times as well.
This PR changes the behaviour so that a CSS file is not fetched more than once.
Testing
Docs