Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix invalid hook usage for exports (#4385)" #4475

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Conversation

matthewp
Copy link
Contributor

This reverts commit 8164fa6.

Changes

Testing

  • The previous change did not contain a test, unfortunately, so doing a revert to prioritize fixing the regression over fixing the bug the regression caused.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2022

🦋 Changeset detected

Latest commit: 66ec6f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/hydration-race Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/solid-recurse Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 25, 2022
@matthewp matthewp merged commit 78334b9 into main Aug 25, 2022
@matthewp matthewp deleted the 1-oh-8-regression branch August 25, 2022 15:42
@astrobot-houston astrobot-houston mentioned this pull request Aug 25, 2022
@deiga
Copy link

deiga commented Aug 30, 2022

Are there plans to re-try #4385 in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading to Astro 1.0.8 breaks @motionone/solid
3 participants