Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Astro 1.0.8 breaks @motionone/solid #4463

Closed
1 task
vxncetxn opened this issue Aug 24, 2022 · 0 comments · Fixed by #4475
Closed
1 task

Upgrading to Astro 1.0.8 breaks @motionone/solid #4463

vxncetxn opened this issue Aug 24, 2022 · 0 comments · Fixed by #4475
Assignees
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority)

Comments

@vxncetxn
Copy link

vxncetxn commented Aug 24, 2022

What version of astro are you using?

1.0.8

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

pnpm

What operating system are you using?

Mac

Describe the Bug

Upgrading Astro to v1.0.8 from previous versions which worked fine such as v1.0.7 somehow breaks @motionone/solid, where this error appears (can also be observed in minimal reproducible example below):

Motion is not defined

/node_modules/@motionone/solid/dist/source/index.jsx:21:47

ReferenceError: Motion is not defined
    at eval (/node_modules/@motionone/solid/dist/source/index.jsx:21:47)
    at async instantiateModule (file:///home/projects/github-hjzgx4/node_modules/vite/dist/node/chunks/dep-0fc8e132.js:50596:9

Some other information that might be relevant:

  1. Version of @motionone/solid is 10.14.1.
  2. Adding of @motionone/solid and @solid-primitives/props to vite.ssr.noExternal in astro.config.mjs is required for it to work without errors in previous versions of Astro.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-hjzgx4

Participation

  • I am willing to submit a pull request for this issue.
@matthewp matthewp added the - P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) label Aug 24, 2022
@matthewp matthewp self-assigned this Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants