Testing perf improvements for e2e tests #4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
tony-sull
force-pushed
the
fix/e2e-test-perf
branch
from
1178ca5 to
44bd785
Compare
tony-sull
changed the title
natemoo-re
approved these changes
Aug 17, 2022
| @@ -18,7 +18,7 @@ export function testFactory(inlineConfig) { | |||
|
|
|||
| const test = testBase.extend({ | |||
| astro: async ({}, use) => { | |||
| fixture = await loadFixture(inlineConfig); | |||
| fixture = fixture || await loadFixture(inlineConfig); | |||
There was a problem hiding this comment.
That's the one! Test suites using beforeAll for firing up the dev server also helps speed up suites a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes a bug that was causing E2E tests to restart the dev server for every single test case
Future improvements - synchronization on HMR tests seem to be flaky on Windows, need to investigate what could be breaking the
editFilesynchronization only for Windows testsTesting
All existing tests should pass...faster
Docs
Test updates only