Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable windows e2e tests #4335

Closed
wants to merge 1 commit into from
Closed

Conversation

natemoo-re
Copy link
Member

Changes

  • Disables Windows E2E tests
  • Makes everyone happier

Testing

Yeah

Docs

No

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2022

⚠️ No Changeset found

Latest commit: 34ec077

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Aug 15, 2022
@matthewp
Copy link
Contributor

matthewp commented Aug 15, 2022

I don't think we should do this without a plan of how/when to run them. Can we make it so that they run only in the CI release PR, for example? That way it's at least caught before a release occurs.

@natemoo-re
Copy link
Member Author

Yeah I'm going to close this! @tony-sull worked on fixing our perf problem in #4354

@natemoo-re natemoo-re closed this Aug 17, 2022
@bluwy bluwy deleted the chore/disable-windows-e2e branch October 8, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants