Unflag the static build #2652

matthewp · 2022-02-24T14:10:27Z

Changes

What does this change?
Be short and concise. Bullet points can help!
Before/after screenshots can be helpful as well.

Testing

About 1/2 of the tests are changed to legacyBuild: true. Most seem small to fix/change.

Docs

No docs needed.

changeset-bot · 2022-02-24T14:10:30Z

🦋 Changeset detected

Latest commit: 475e596

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
astro	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/astro/src/@types/astro.ts

yarn.lock

jonathantneal

Left a note about a change to yarn.lock, but otherwise nice!

tony-sull

Looks good to me too (pending Jonathan's yarn.lock question)

FredKSchott

don't forget to replace the PR template :) otherwise LGTM

FredKSchott · 2022-02-25T16:10:35Z

packages/astro/src/@types/astro.ts

@@ -27,8 +27,12 @@ export interface CLIFlags {
 	hostname?: string;
 	port?: number;
 	config?: string;
+	/**
+	 * @deprecated


nit: /** @deprecated */

* Unflag the static build * Only set legacyBuild to false if experimentalSSR is true * Use legacy build when we have to * Put a few more tests into legacy mode * Last two * Make astro-basic use the legacy build * Adds a changeset * Mark the lit test as legacy * Update yarn lock * Update based on feedback * Add --legacy-build flag

* Unflag the static build (#2652) * Unflag the static build * Only set legacyBuild to false if experimentalSSR is true * Use legacy build when we have to * Put a few more tests into legacy mode * Last two * Make astro-basic use the legacy build * Adds a changeset * Mark the lit test as legacy * Update yarn lock * Update based on feedback * Add --legacy-build flag * Move astro-basic test to use static build (#2682) * Move some tests over to the static build (#2677) * Move some tests over to the static build * Fix assets tests * Fix the assets tests * Fix for the client:only components * Moves asset tests to the static build * Move postcss test over to static build * Bring back legacy build for astro-basic test * Move astro-basic test to use static build * Migrate more tests to the static build (#2693) * fix: disable HMR during build (#2684) * Migrate more tests to the static build * Only prepend links in non-legacy mode * Add the 0-css tests * Convert all CSS tests to the static build * Migrate Astro global tests * Remove .only * Fix static build tests * Migrate a few more * More tests * Move the lit test back to legacy * Increase the test timeout Co-authored-by: Nate Moore <[email protected]> * Improve `head` injection behavior (#2436) * feat: add renderHead util to server * feat: remove `layouts` from config, Vite plugin * fix: improve head injection during rendering * chore: update compiler * fix: do not escape links * chore: enter `pre` mode * Replace `send` with `sirv` (#2713) * remove send * Create thick-ravens-chew.md * I feel like I'm going to screw something up * working finally! * rewrite req.url * Add tiny bit of doc * Update .gitignore Co-authored-by: Evan Boehs <[email protected]> * Move remaining tests to the static build (#2712) * Move lit test to the static build * Migrate astro-env plugin to work in the static build * Do not remove vite:define * Adds a changeset * Add a warning when passing the --experimental-static-build flag (#2718) * Add a warning when passing the --experimental-static-build flag * Disable the lint warning * [ci] release (next) (#2721) * [ci] release (next) * chore: update changeset Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nate Moore <[email protected]> * 404 page (#2719) * Fix: build to 404.html in the static build * Adds a changeset * fix pnpm install missing peer deps * fix svelte version in workspace * fix lockfile * fix(webapi): add dev script * improve preview reliability (#2739) * improve preview reliability - fix broken tests * shamefully hoist to unblock * remove lit from test running * chore: update lockfile Co-authored-by: Matthew Phillips <[email protected]> Co-authored-by: Evan Boehs <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Fred K. Schott <[email protected]>

* Unflag the static build (withastro#2652) * Unflag the static build * Only set legacyBuild to false if experimentalSSR is true * Use legacy build when we have to * Put a few more tests into legacy mode * Last two * Make astro-basic use the legacy build * Adds a changeset * Mark the lit test as legacy * Update yarn lock * Update based on feedback * Add --legacy-build flag * Move astro-basic test to use static build (withastro#2682) * Move some tests over to the static build (withastro#2677) * Move some tests over to the static build * Fix assets tests * Fix the assets tests * Fix for the client:only components * Moves asset tests to the static build * Move postcss test over to static build * Bring back legacy build for astro-basic test * Move astro-basic test to use static build * Migrate more tests to the static build (withastro#2693) * fix: disable HMR during build (withastro#2684) * Migrate more tests to the static build * Only prepend links in non-legacy mode * Add the 0-css tests * Convert all CSS tests to the static build * Migrate Astro global tests * Remove .only * Fix static build tests * Migrate a few more * More tests * Move the lit test back to legacy * Increase the test timeout Co-authored-by: Nate Moore <[email protected]> * Improve `head` injection behavior (withastro#2436) * feat: add renderHead util to server * feat: remove `layouts` from config, Vite plugin * fix: improve head injection during rendering * chore: update compiler * fix: do not escape links * chore: enter `pre` mode * Replace `send` with `sirv` (withastro#2713) * remove send * Create thick-ravens-chew.md * I feel like I'm going to screw something up * working finally! * rewrite req.url * Add tiny bit of doc * Update .gitignore Co-authored-by: Evan Boehs <[email protected]> * Move remaining tests to the static build (withastro#2712) * Move lit test to the static build * Migrate astro-env plugin to work in the static build * Do not remove vite:define * Adds a changeset * Add a warning when passing the --experimental-static-build flag (withastro#2718) * Add a warning when passing the --experimental-static-build flag * Disable the lint warning * [ci] release (next) (withastro#2721) * [ci] release (next) * chore: update changeset Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nate Moore <[email protected]> * 404 page (withastro#2719) * Fix: build to 404.html in the static build * Adds a changeset * fix pnpm install missing peer deps * fix svelte version in workspace * fix lockfile * fix(webapi): add dev script * improve preview reliability (withastro#2739) * improve preview reliability - fix broken tests * shamefully hoist to unblock * remove lit from test running * chore: update lockfile Co-authored-by: Matthew Phillips <[email protected]> Co-authored-by: Evan Boehs <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Fred K. Schott <[email protected]>

Unflag the static build

9c3467d

github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 24, 2022

matthewp added 2 commits February 24, 2022 10:53

Only set legacyBuild to false if experimentalSSR is true

3261c5a

Use legacy build when we have to

5866f67

github-actions bot added the test label Feb 24, 2022

matthewp added 2 commits February 24, 2022 11:20

Put a few more tests into legacy mode

e1610f2

Last two

c1c6075

matthewp changed the base branch from main to next February 24, 2022 17:21

matthewp added 3 commits February 24, 2022 12:23

Make astro-basic use the legacy build

98673fc

Adds a changeset

6183142

Mark the lit test as legacy

48853c3

matthewp marked this pull request as ready for review February 24, 2022 17:52

jonathantneal reviewed Feb 24, 2022

View reviewed changes

packages/astro/src/@types/astro.ts Show resolved Hide resolved

jonathantneal reviewed Feb 24, 2022

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

jonathantneal approved these changes Feb 24, 2022

View reviewed changes

tony-sull approved these changes Feb 25, 2022

View reviewed changes

FredKSchott approved these changes Feb 25, 2022

View reviewed changes

matthewp added 3 commits February 25, 2022 11:24

Update yarn lock

9a6e010

Update based on feedback

d8287d9

Add --legacy-build flag

475e596

matthewp merged commit 9c15587 into next Feb 25, 2022

matthewp deleted the sb-unflagged branch February 25, 2022 22:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unflag the static build #2652

Unflag the static build #2652

matthewp commented Feb 24, 2022 •

edited

Loading

changeset-bot bot commented Feb 24, 2022 •

edited

Loading

jonathantneal left a comment

tony-sull left a comment

FredKSchott left a comment

FredKSchott Feb 25, 2022

Unflag the static build #2652

Unflag the static build #2652

Conversation

matthewp commented Feb 24, 2022 • edited Loading

Changes

Testing

Docs

changeset-bot bot commented Feb 24, 2022 • edited Loading

🦋 Changeset detected

jonathantneal left a comment

Choose a reason for hiding this comment

tony-sull left a comment

Choose a reason for hiding this comment

FredKSchott left a comment

Choose a reason for hiding this comment

FredKSchott Feb 25, 2022

Choose a reason for hiding this comment

matthewp commented Feb 24, 2022 •

edited

Loading

changeset-bot bot commented Feb 24, 2022 •

edited

Loading