Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions stable release #11843

Merged
merged 27 commits into from
Aug 29, 2024
Merged

Actions stable release #11843

merged 27 commits into from
Aug 29, 2024

Conversation

bholmesdev
Copy link
Contributor

Changes

This makes Actions stable for v4.15.

  • Remove experimental flag
  • Remove deprecated getActionProps() API
  • Add check for whether actions are used before mounting routes and middleware
  • Add check for a define action symbol before registering an action function. Maybe overkill, but this 100% ensures the change is non-breaking for users that happen to have an actions/index.ts file that isn't actions related.

Testing

Remove experimental flag and getActionProps() from tests

Docs

withastro/docs#8980

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 0613a2b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review semver: minor Change triggers a `minor` release labels Aug 26, 2024
github-actions[bot]
github-actions bot previously requested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@bholmesdev
Copy link
Contributor Author

@florian-lefebvre I revisited your comment on simplifying the integration. I realized we could do so! I split things up so we have vitePluginActions() to define the astro:actions, module, and the astroIntegrationActionsRouterHandler() to only inject routes when actions are used. I moved that file watcher to a vite plugin. Should solve a failing test in the process too 👍

@bholmesdev bholmesdev force-pushed the feat/actions-stable branch from 48fbd8e to 6dce616 Compare August 27, 2024 18:55
sarah11918
sarah11918 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just giving Ben more permission to hype it up in the changeset as he sees fit! Errors nicely updated as well! Approving for docs!

.changeset/spicy-suits-explode.md Outdated Show resolved Hide resolved
ematipico
ematipico reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some reservations on how we load the actions file, because it adds yet another way to do things.

I don't want to block the PR, but I believe we should address it.

packages/astro/src/actions/plugins.ts Outdated Show resolved Hide resolved
packages/astro/src/actions/runtime/virtual/get-action.ts Outdated Show resolved Hide resolved
packages/astro/src/actions/utils.ts Outdated Show resolved Hide resolved
packages/astro/src/actions/utils.ts Show resolved Hide resolved
@ematipico ematipico added this to the 4.15 milestone Aug 28, 2024
@bholmesdev
fix(test): pass default src dir
fd56de6
@bholmesdev
feat: add ActionNotFoundError
d6576fc
@bholmesdev
fix: handle json parse errors in deserializer
f4b4242
@bholmesdev
chore: unused import
08ef1b2
@bholmesdev
500 -> 404
cf49c7d
@bholmesdev
New astro:schema module (#11810)
2b5e2f5 
* feat: expose zod from astro:schema

* chore: changeset

* chore: update release strategy in changeset

* fix: move deprecated notice to type def

* fix: update config doc reference

* chore: remove z from astro:actions

* edit: changeset with minor release note remove

* wip: increase button click timeouts

* Revert "wip: increase button click timeouts"

This reverts commit a870bc2.

* chore: remove content collections disclaimer

* fix: undo biome change

* agh tabs

* agh newlines

* fix: bad docs merge

* wip: add back timeout extension

* fix(test): astro schema import
@bholmesdev
refactor: move static output error to config done
d94d314
@bholmesdev
refactor: usesActions -> isActionsFilePresent
d5f2711
@bholmesdev
fix: check whether startup and current value disagree
b9c277f
@bholmesdev
chore: unused import
8bd3ed4
@bholmesdev bholmesdev force-pushed the feat/actions-stable branch from 967c560 to 8bd3ed4 Compare August 28, 2024 20:08
sarah11918
sarah11918 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little changeset nit, otherwise both changesets are approved by docs!

.changeset/spicy-suits-explode.md Outdated Show resolved Hide resolved
@ematipico ematipico merged commit 5b4070e into main Aug 29, 2024
14 checks passed
@ematipico ematipico deleted the feat/actions-stable branch August 29, 2024 10:13
@astrobot-houston astrobot-houston mentioned this pull request Aug 29, 2024
Merged
@kenedyolisi
Copy link

Actions is one of the many features I love in astro. I couldn't wait for it to be stable and the provided guide is so extensive. I looove it. Thanks to @bholmesdev for tremendous effort on this and other contributors too for this feature.

@bholmesdev
Copy link
Contributor Author

Ah, you made my day! Thanks @kenedyolisi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

@bluwy bluwy bluwy approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

@ematipico ematipico ematipico approved these changes

@matthewp matthewp matthewp approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
docs pr pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review semver: minor Change triggers a `minor` release
Projects
None yet
Milestone
4.15
Development

Successfully merging this pull request may close these issues.
7 participants
@bholmesdev @kenedyolisi @matthewp @ematipico @sarah11918 @bluwy @florian-lefebvre