-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New astro:schema
module
#11810
New astro:schema
module
#11810
Conversation
🦋 Changeset detectedLatest commit: aeadfc0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changeset looks very helpful @bholmesdev ! I'd suggest updating the config reference (experimental) docs at the same time while you're here so that there isn't conflicting information in the docs with this recommended advice! (It should just be the one example of defining the action.)
@sarah11918 Ah ha, forgot about the config reference docs! I'll update those as well |
Also noting I don't yet see a Linear task for Deprecating z from content in the Astro 5.0 Linear project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed about that on Discord a little bit and not everyone is in favor of using virtual modules for things that don't need them (eg. zod does not depend on some vite only stuff). If possible, I'd prefer to setup a call about astro:schema
and virtual modules for 5.0 and use astro/zod
in the meantime, or just deprecate z
from astro:actions
saying there will be an alternative soon.
Concerned messages:
This is not the right time to discuss if virtual modules are always right, that's a post 5.0 topic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
This reverts commit a870bc2.
a870bc2
to
a2f79a5
Compare
Merging into actions-stable, not main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
* feat: expose zod from astro:schema * chore: changeset * chore: update release strategy in changeset * fix: move deprecated notice to type def * fix: update config doc reference * chore: remove z from astro:actions * edit: changeset with minor release note remove * wip: increase button click timeouts * Revert "wip: increase button click timeouts" This reverts commit a870bc2. * chore: remove content collections disclaimer * fix: undo biome change * agh tabs * agh newlines * fix: bad docs merge * wip: add back timeout extension * fix(test): astro schema import
* feat: baseline experimental actions * feat(test): remove experimental config * feat: remove getActionProps() * feat: make actions file non-break * feat: detect actions usage * chore: changeset * feat: improve actions usage check * refactor: remove define action symbol now that we check server exp * fix: remove old import * chore: move actionsIntegration to top import * fix: warn only when actions are used * fix: srcDir check * refactor: split out action plugins to simplify integration * feat: new integration and plugins * chore: update error hints * fix(test): pass default src dir * feat: add ActionNotFoundError * fix: handle json parse errors in deserializer * chore: unused import * 500 -> 404 * New `astro:schema` module (#11810) * feat: expose zod from astro:schema * chore: changeset * chore: update release strategy in changeset * fix: move deprecated notice to type def * fix: update config doc reference * chore: remove z from astro:actions * edit: changeset with minor release note remove * wip: increase button click timeouts * Revert "wip: increase button click timeouts" This reverts commit a870bc2. * chore: remove content collections disclaimer * fix: undo biome change * agh tabs * agh newlines * fix: bad docs merge * wip: add back timeout extension * fix(test): astro schema import * refactor: move static output error to config done * refactor: usesActions -> isActionsFilePresent * fix: check whether startup and current value disagree * chore: unused import * edit: sell actions a little more * changeset nit --------- Co-authored-by: Sarah Rainsberger <[email protected]>
Changes
Introduces
astro:schema
. This is planned to be the single place to importz
across Astro features. This means a nasty short-term set of competing standards acrossastro:actions
andastro:content
. Intended release strategy:z
fromastro:actions
in the next minorz
inastro:content
for 5.0. (to be discussed)Testing
Update test fixtures to use
astro:schema
Docs
Update Actions docs preview to use
astro:schema