fix: better logging for rewrites #11505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: be104be The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
florian-lefebvre
approved these changes
Jul 19, 2024
|
I'd find it confusing to have the status of what the request would have been without a rewrite. The target is the one I'm interested in. Showing that it has been rewritten is good though. |
ematipico
force-pushed
the
chore/better-logging-rewrites
branch
from
fd130c7 to
be104be
Compare
Feedback applied |
ascorbic
approved these changes
Jul 19, 2024
delucis
approved these changes
Jul 19, 2024
Merged
1 task
This was referenced Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR enhances the logging of the dev server when there's a rewrite
Testing
I tested locally
The logic of the colours stays the same, which means the colour reflects the final status code.
Docs