apply feedback

withastro · Jul 19, 2024 · be104be · be104be
1 parent 093b5ee
commit be104be
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 12 deletions.
diff --git a/.changeset/blue-jars-hang.md b/.changeset/blue-jars-hang.md
@@ -7,6 +7,6 @@ Enhances the dev server logging when rewrites occur during the lifecycle or rend
 The dev server will log the status code **before** and **after** a rewrite:
 
 ```shell
-08:16:48 [404 → rewrite → 200] /foo/about 200ms
-08:22:13 [200 → rewrite → 404] /about 23ms
+08:16:48 [404] (rewrite) /foo/about 200ms
+08:22:13 [200] (rewrite) /about 23ms
 ```
diff --git a/packages/astro/src/core/messages.ts b/packages/astro/src/core/messages.ts
@@ -36,24 +36,19 @@ export function req({
 	method,
 	statusCode,
 	reqTime,
-	formerStatusCode,
+	isRewrite,
 }: {
 	url: string;
 	statusCode: number;
 	method?: string;
 	reqTime?: number;
-	formerStatusCode?: number;
+	isRewrite?: boolean;
 }): string {
 	const color = statusCode >= 500 ? red : statusCode >= 300 ? yellow : blue;
-	let statusCodeLabel;
-	if (formerStatusCode) {
-		statusCodeLabel = color(`[${formerStatusCode} → rewrite → ${statusCode}]`);
-	} else {
-		statusCodeLabel = color(`[${statusCode}]`);
-	}
 	return (
-		statusCodeLabel +
+		color(`[${statusCode}]`) +
 		` ` +
+		`${isRewrite ? color('(rewrite) ') : ''}` +
 		(method && method !== 'GET' ? color(method) + ' ' : '') +
 		url +
 		` ` +

diff --git a/packages/astro/src/vite-plugin-astro-server/route.ts b/packages/astro/src/vite-plugin-astro-server/route.ts
@@ -233,7 +233,7 @@ export async function handleRoute({
 				url: pathname,
 				method: incomingRequest.method,
 				statusCode: isRewrite ? response.status : (status ?? response.status),
-				formerStatusCode: isRewrite ? status : undefined,
+				isRewrite,
 				reqTime: timeEnd - timeStart,
 			})
 		);