Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes toggleState #10933

Merged
merged 1 commit into from
May 2, 2024
Merged

Fixes toggleState #10933

merged 1 commit into from
May 2, 2024

Conversation

Princesseuh
Copy link
Member

Changes

Oops, not using the right event.

Fix #10932

Testing

Tested manually

Docs

N/A

Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: 877cf66

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 2, 2024
@ktym4a
Copy link
Contributor

ktym4a commented May 2, 2024

@Princesseuh
I would like to ask one related question.
https://docs.astro.build/en/reference/dev-toolbar-app-reference/#togglestate
Is there a reason why the docs are changeAppState? Or should it be fixed?

@Princesseuh
Copy link
Member Author

@Princesseuh I would like to ask one related question. https://docs.astro.build/en/reference/dev-toolbar-app-reference/#togglestate Is there a reason why the docs are changeAppState? Or should it be fixed?

Yes, looks like it's outdated! It was changed close to release, so we might've missed this.

@ktym4a
Copy link
Contributor

ktym4a commented May 2, 2024

Okay, Thanks.
I will send PR for that to docs!

@Princesseuh Princesseuh merged commit 007d17f into main May 2, 2024
13 checks passed
@Princesseuh Princesseuh deleted the fix/toggle-app branch May 2, 2024 08:31
@astrobot-houston astrobot-houston mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toolbar: toggleState is not working.
3 participants