Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolbar: toggleState is not working. #10932

Closed
1 task done
ktym4a opened this issue May 2, 2024 · 2 comments · Fixed by #10933
Closed
1 task done

toolbar: toggleState is not working. #10932

ktym4a opened this issue May 2, 2024 · 2 comments · Fixed by #10933

Comments

@ktym4a
Copy link
Contributor

ktym4a commented May 2, 2024

Astro Info

Astro                    v4.7.0
Node                     v20.10.0
System                   macOS (arm64)
Package Manager          npm
Output                   static
Adapter                  none
Integrations             none

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

If toggleState is the same as before this,

app.dispatchEvent(
    new CustomEvent("toggle-app", {
        detail: {
            state: false,
        },
    }),
);

App does not close when I call the following

app.toggleState({
    state: false,
});

What's the expected result?

If the same behavior is assumed, app should close.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-um5tv1?file=app.ts

Participation

  • I am willing to submit a pull request for this issue.

If my understanding is correct, I will send PR.

@github-actions github-actions bot added the needs triage Issue needs to be triaged label May 2, 2024
@florian-lefebvre florian-lefebvre added the needs repro Issue needs a reproduction label May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

Hello @ktym4a. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with needs repro will be closed if they have no activity within 3 days.

@github-actions github-actions bot removed the needs triage Issue needs to be triaged label May 2, 2024
@ktym4a
Copy link
Contributor Author

ktym4a commented May 2, 2024

added repro

@Princesseuh Princesseuh removed the needs repro Issue needs a reproduction label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants