Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type error in seed stub on initial setup #10457

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Mar 15, 2024

Changes

You got a type error in your config/seed.ts before type generation since db was part of the generated types file. db is a static value, so we can move this to the base virtual module types to avoid the type error.

  • Move db type to virtual module types
  • Rename SQLiteDB - > LibSQLDatabase
  • Misc: move types for sql and NOW utilities to runtime/config.ts for consistency

Testing

pnpm pack to ensure types line up

Docs

Copy link

changeset-bot bot commented Mar 15, 2024

🦋 Changeset detected

Latest commit: 2d242d0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants