Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astro DB no longer exports type Sqlitedb #15

Closed
OliverSpeir opened this issue Jun 6, 2024 · 4 comments
Closed

Astro DB no longer exports type Sqlitedb #15

OliverSpeir opened this issue Jun 6, 2024 · 4 comments

Comments

@OliverSpeir
Copy link

Doesn’t break anything but figured it was worth noting

https://github.com/pilcrowOnPaper/lucia-adapter-astrodb/blob/ecefa40be925b877e4bdf22b833fae1ce601f2f2/src/index.ts#L4

Think this was changed in withastro/astro#10457

Thanks so much for making this by the way, if you have an idea for how you want to do the type I could make a PR

@OliverSpeir OliverSpeir changed the title Astro no longer exports type Sqlitedb Astro DB no longer exports type Sqlitedb Jun 6, 2024
@pilcrowonpaper
Copy link
Owner

pilcrowonpaper commented Jun 8, 2024

I can't seem to find a type to replace it with so this might need an action from Astro's side. Trying to confirm this with the maintainers right now

@OliverSpeir
Copy link
Author

Ok so withastro/astro#11216 starts exporting the type again which should go out with @astrojs/[email protected]

Now the consideration is that the type has been (accurately) renamed to Database instead of SqliteDB

@pilcrowonpaper
Copy link
Owner

Thanks for making the PR!

@millette
Copy link
Contributor

millette commented Jul 4, 2024

@pilcrowonpaper I didn't see a PR here for this issue so I made #16.

I was a little bit confused since the git tag says 0.0.8 but the npm published version is 0.0.9.

pilcrowonpaper added a commit that referenced this issue Aug 17, 2024
Fix #15 Astro DB no longer exports type Sqlitedb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants