Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken hls-hlint-plugin in nix env #2629

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Fix broken hls-hlint-plugin in nix env #2629

merged 3 commits into from
Aug 18, 2022

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Aug 18, 2022 •
edited
Loading

This PR applies this suggestion NixOS/nixpkgs#168064 (comment)
in a wire's nixpkgs fork. Since the problem has been fixed in haskell/haskell-language-server#2854 we can switch to nixos/nixpkgs once a new HLS version is released an available in nixpkgs.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@smatting smatting added the not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR label Aug 18, 2022
@smatting smatting temporarily deployed to cachix August 18, 2022 12:58 Inactive
@smatting smatting temporarily deployed to cachix August 18, 2022 12:58 Inactive
@smatting smatting temporarily deployed to cachix August 18, 2022 12:59 Inactive
@smatting smatting temporarily deployed to cachix August 18, 2022 12:59 Inactive
@smatting smatting marked this pull request as ready for review August 18, 2022 13:01
@smatting smatting requested a review from pcapriotti August 18, 2022 13:08
@flokli
Copy link
Contributor

flokli commented Aug 18, 2022

Nixpkgs PR: NixOS/nixpkgs#187284

@smatting smatting temporarily deployed to cachix August 18, 2022 14:12 Inactive
@smatting smatting temporarily deployed to cachix August 18, 2022 14:12 Inactive
@smatting
Copy link
Contributor Author

I tested again: it works! Squiggly lines

@smatting smatting merged commit b126af8 into develop Aug 18, 2022
@smatting smatting deleted the smatting/hls-hlint-plugin branch August 18, 2022 14:20
@zebot zebot mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti Awaiting requested review from pcapriotti

Assignees
No one assigned
Labels
not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smatting @flokli