Support hls-hlint-plugin and hls-stylish-plugin for ghc9.0 and ghc9.2 #2854

July541 · 2022-04-25T13:14:06Z

No description provided.

pepeiborra · 2022-04-25T22:45:41Z

What about 9.0? Should be able to play the same trick

July541 · 2022-04-26T04:57:53Z

What about 9.0? Should be able to play the same trick

Haha, sorry for my unclear words, I just want to express that this pr will support hlint-plugin and stylish-haskell-plugin to 9.2(include any version less than 9.2)

michaelpj

Can you also update the plugin support table in the docs when this is ready? (#2840 brings it up to date with the current state, but this PR makes it better!)

plugins/hls-class-plugin/src/Ide/Plugin/Class.hs

michaelpj · 2022-04-26T09:06:27Z

cabal-ghc92.project

+  hlint +ghc-lib,
+  stylish-haskell +ghc-lib
+
+source-repository-package


Why do we need this? when can we remove it?

Due to the limitation of hls-hlint-plugin code structure, we must force ghc-lib-parser uses ghc-lib instead of ghc to make compile, this repo adds a flag to allow us to force use ghc-lib in stylish-haskell(or is there another way to do this with out edit the package?)

Why do we have to use ghc-lib?

We have two code path in hls-hlint-plugin, includes using ghc and using ghc-lib. the ghc codebase relies on our compiled module by getParsedModuleWithComments which has some ann operation that ghc-9.2 has totally different views, we can make ghc-9.2 also use this after some revise(Not much work, but will introduce more complex compat). The ghc-lib codebase parses the source code directly and we can use this for any ghc-lib easily.

We use apply-refact to apply hlint, and for ghc before 9.2, it requires apply-refact-0.9 and in ghc-9.2, it needs apply-refact-0.10. Since in ghc codebase we pass parsed module to apply-refact, it works in 0.9 but not in 0.10. apply-refact-0.10 uses an internal IORef(https://github.com/mpickering/apply-refact/blob/cb8464af74ce9c1cee26fa4862c713bb5ff96114/src/Refact/Internal.hs#L751-L755) and the only entrance is parse the source by apply-refact. (https://github.com/mpickering/apply-refact/blob/cb8464af74ce9c1cee26fa4862c713bb5ff96114/src/Refact/Internal.hs#L709). If we still pass a parsed module to apply-refact-0.10, it crashed with undefined(https://github.com/mpickering/apply-refact/blob/cb8464af74ce9c1cee26fa4862c713bb5ff96114/src/Refact/Internal.hs#L557)

I think we can remove this after the new stylish-haskell with ghc-lib flag is released.

It looks we can turn to ghc-lib and abandon ghc in hls-hlint-plugin, can we?

Pr created haskell/stylish-haskell#402

michaelpj · 2022-04-26T09:07:02Z

plugins/hls-fourmolu-plugin/hls-fourmolu-plugin.cabal

@@ -23,7 +23,7 @@ library
  build-depends:
    , base            >=4.12 && <5
    , filepath
-    , fourmolu        ^>=0.3 || ^>=0.4 || ^>= 0.5
+    , fourmolu        ^>=0.3 || ^>=0.4 || ^>= 0.6


Do we need to disallow 0.5 or should we just add 0.6?

0.5 and 0.6 have the same requirements but 0.6 has bug fix, I don't think we have a reason to allow 0.5. https://github.com/fourmolu/fourmolu/blob/master/CHANGELOG.md

plugins/hls-hlint-plugin/test/Main.hs

michaelpj · 2022-04-27T09:45:50Z

plugins/hls-class-plugin/hls-class-plugin.cabal

@@ -28,6 +28,7 @@ library
    , base            >=4.12 && <5
    , containers
    , ghc
+    -- Require ghc-exactprint >= 1.5 on ghc9.2


did you mean to also actually change the bound?

oops, I think we can only add a constraint in .project or stack-x.yaml since ghc-exactprint-0.6 is required from ghc8 to ghc9.0. I'll add a comment here.

Unfuntunately, just a comment.

You could have a cabal conditional based on the GHC version? Maybe it's not worth it.

July541 · 2022-04-27T13:19:24Z

I think this pr is ready to be merged. Everything is ok except the nix config, we have a working pr to upgrade it, #2853, we can add nix contents after nix scripts upgrade.

eddiemundo

LGTM. Can't comment on the ghc-lib stuff because I never really understood it.

…haskell#2854) * hls-hlint-plugin & hls-stylish-haskell-plugin rush to ghc92 * Restore allow-newer * Add BufSpan for lower version ghc * Add Cabal constraint for stack-9.0.1.yaml * Try ghc-lib-parser for BufSpan * Loose tactic compiling constraint * Rename hlint34 * Rerun test * Update doc * Comment ghc-exactprint requirements * Add test for apply-refact-0.10 * Use hackage stylish-haskell * ghc-exactprint constraints for hls-class-plugin * Remove uncompiled if Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

… ghc9.2 (haskell#2854)

July541 added 5 commits April 25, 2022 21:13

hls-hlint-plugin & hls-stylish-haskell-plugin rush to ghc92

625824d

Restore allow-newer

8fbc1ea

Add BufSpan for lower version ghc

f2c8ca3

Add Cabal constraint for stack-9.0.1.yaml

ae54504

Try ghc-lib-parser for BufSpan

af182dd

July541 force-pushed the hlint-9.2 branch from c8cf73d to af182dd Compare April 25, 2022 16:25

Loose tactic compiling constraint

7e1e64e

July541 changed the title ~~Support hls-hlint-plugin and hls-stylish-plugin to ghc9.2~~ Support hls-hlint-plugin and hls-stylish-plugin for ghc9.0 and ghc9.2 Apr 26, 2022

July541 added 2 commits April 26, 2022 14:31

Rename hlint34

a66395f

Rerun test

27a1174

michaelpj reviewed Apr 26, 2022

View reviewed changes

July541 added 4 commits April 27, 2022 13:24

Merge branch 'master' into hlint-9.2

2995411

Update doc

0f2d692

Comment ghc-exactprint requirements

2362e66

Add test for apply-refact-0.10

7690421

July541 mentioned this pull request Apr 27, 2022

Add ghc-lib flag to force use ghc-lib-parser even if ghc is supported haskell/stylish-haskell#402

Merged

michaelpj reviewed Apr 27, 2022

View reviewed changes

July541 added 4 commits April 27, 2022 18:32

Use hackage stylish-haskell

ecdaed0

ghc-exactprint constraints for hls-class-plugin

d4c1a93

Remove uncompiled if

d36688f

Merge branch 'master' into hlint-9.2

52442e5

July541 marked this pull request as ready for review April 27, 2022 13:19

July541 requested review from jneira, Anton-Latukha, Ailrun, eddiemundo and georgefst as code owners April 27, 2022 13:19

eddiemundo approved these changes Apr 28, 2022

View reviewed changes

michaelpj approved these changes Apr 28, 2022

View reviewed changes

michaelpj added the merge me Label to trigger pull request merge label Apr 28, 2022

Merge branch 'master' into hlint-9.2

e3e3888

mergify bot merged commit c14cbdb into haskell:master Apr 28, 2022

anka-213 mentioned this pull request May 26, 2022

hls-hlint-plugin: Build fails with ghc-lib >= 9.0 and ghc <= 8.10.7 #2728

Closed

smatting mentioned this pull request Aug 18, 2022

Fix broken hls-hlint-plugin in nix env wireapp/wire-server#2629

Merged

4 tasks

flokli mentioned this pull request Aug 18, 2022

haskell-language-server: fix with ghc-lib >= 9.0 and ghc <= 8.10.7 NixOS/nixpkgs#187284

Merged

13 tasks

hololeap added a commit to hololeap/haskell-language-server that referenced this pull request Aug 26, 2022

fixup! Support hls-hlint-plugin and hls-stylish-plugin for ghc9.0 and…

8a34e19

… ghc9.2 (haskell#2854)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support hls-hlint-plugin and hls-stylish-plugin for ghc9.0 and ghc9.2 #2854

Support hls-hlint-plugin and hls-stylish-plugin for ghc9.0 and ghc9.2 #2854

July541 commented Apr 25, 2022

pepeiborra commented Apr 25, 2022

July541 commented Apr 26, 2022

michaelpj left a comment

michaelpj Apr 26, 2022

July541 Apr 26, 2022 •

edited

Loading

July541 Apr 26, 2022

July541 Apr 27, 2022

michaelpj Apr 26, 2022

July541 Apr 26, 2022

michaelpj Apr 27, 2022

July541 Apr 27, 2022

michaelpj Apr 27, 2022

July541 commented Apr 27, 2022

eddiemundo left a comment

Support hls-hlint-plugin and hls-stylish-plugin for ghc9.0 and ghc9.2 #2854

Support hls-hlint-plugin and hls-stylish-plugin for ghc9.0 and ghc9.2 #2854

Conversation

July541 commented Apr 25, 2022

pepeiborra commented Apr 25, 2022

July541 commented Apr 26, 2022

michaelpj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

July541 Apr 26, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

July541 commented Apr 27, 2022

eddiemundo left a comment

Choose a reason for hiding this comment

July541 Apr 26, 2022 •

edited

Loading