Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Proteus federation if MLS not supported by backend (WPB-14456) 🍒 #3685

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


StoryWPB-14456 [Android] Still allow usage of federation for proteus in some cases


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to support federation search, according to if MLS is enabled, or if it is configured or not in the backend.

Solutions

Create a new use case centralizing the logic to decide if we need to support federation or not for this: team/conversation/backend.

Before the logic was in the view model in AR, but here is centralized and we can test all the cases for it, therefore now the view model just calls this use case to decide if we need to enable cross domain search.

Dependencies (Optional)

A PR will follow in AR.

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch DO NOT MERGE echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud size/XS labels Nov 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.75%. Comparing base (7983260) to head (90b1d11).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3685      +/-   ##
===========================================
- Coverage    45.76%   45.75%   -0.02%     
===========================================
  Files          472      472              
  Lines        16027    16020       -7     
  Branches      2708     2704       -4     
===========================================
- Hits          7335     7330       -5     
  Misses        7929     7929              
+ Partials       763      761       -2     
Files with missing lines Coverage Δ
...i/home/conversations/search/SearchUserViewModel.kt 97.29% <100.00%> (+2.23%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7983260...90b1d11. Read the comment docs.

Copy link
Contributor Author

Built wire-android-staging-compat-pr-3685.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3685.apk is available for download

Copy link

sonarcloud bot commented Dec 2, 2024

@yamilmedina yamilmedina added this pull request to the merge queue Dec 2, 2024
Copy link
Contributor Author

github-actions bot commented Dec 2, 2024

Built wire-android-staging-compat-pr-3685.apk is available for download

Copy link
Contributor Author

github-actions bot commented Dec 2, 2024

Built wire-android-dev-debug-pr-3685.apk is available for download

Merged via the queue into develop with commit 0e55e69 Dec 2, 2024
11 of 12 checks passed
@yamilmedina yamilmedina deleted the feat/support-proteus-federation-if-mls-disabled-cherry-pick branch December 2, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants