Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Proteus federation if MLS not supported by backend (WPB-14456) #3668

Merged

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Nov 26, 2024

StoryWPB-14456 [Android] Still allow usage of federation for proteus in some cases


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to support federation search, according to if MLS is enabled, or if it is configured or not in the backend.

Solutions

Create a new use case centralizing the logic to decide if we need to support federation or not for this: team/conversation/backend.

Before the logic was in the view model in AR, but here is centralized and we can test all the cases for it, therefore now the view model just calls this use case to decide if we need to enable cross domain search.

Dependencies (Optional)

A PR will follow in AR.

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.94%. Comparing base (7720cdd) to head (7dd35e2).
Report is 1 commits behind head on release/candidate.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3668      +/-   ##
=====================================================
- Coverage              44.95%   44.94%   -0.02%     
=====================================================
  Files                    471      471              
  Lines                  15732    15725       -7     
  Branches                2690     2686       -4     
=====================================================
- Hits                    7073     7068       -5     
  Misses                  7901     7901              
+ Partials                 758      756       -2     
Files with missing lines Coverage Δ
...i/home/conversations/search/SearchUserViewModel.kt 97.29% <100.00%> (+2.23%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7720cdd...7dd35e2. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3668.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3668.apk is available for download

@yamilmedina yamilmedina changed the title feat: support Proteus federation if MLS not supported by backend (WPB-14250) feat: support Proteus federation if MLS not supported by backend (WPB-14456) Nov 27, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3668.apk is available for download

@yamilmedina yamilmedina force-pushed the feat/support-proteus-federation-if-mls-disabled branch from 9784c59 to 7dd35e2 Compare November 28, 2024 14:15
Copy link

sonarcloud bot commented Nov 28, 2024

Copy link
Contributor

Built wire-android-staging-compat-pr-3668.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Nov 29, 2024
Merged via the queue into release/candidate with commit aed7ea8 Nov 29, 2024
13 checks passed
@yamilmedina yamilmedina deleted the feat/support-proteus-federation-if-mls-disabled branch November 29, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants