-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Proteus federation if MLS not supported by backend (WPB-14456) #3668
feat: support Proteus federation if MLS not supported by backend (WPB-14456) #3668
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3668 +/- ##
=====================================================
- Coverage 44.95% 44.94% -0.02%
=====================================================
Files 471 471
Lines 15732 15725 -7
Branches 2690 2686 -4
=====================================================
- Hits 7073 7068 -5
Misses 7901 7901
+ Partials 758 756 -2
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3668.apk is available for download |
Built wire-android-staging-compat-pr-3668.apk is available for download |
Built wire-android-staging-compat-pr-3668.apk is available for download |
9784c59
to
7dd35e2
Compare
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3668.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We need to support federation search, according to if MLS is enabled, or if it is configured or not in the backend.
Solutions
Create a new use case centralizing the logic to decide if we need to support federation or not for this: team/conversation/backend.
Before the logic was in the view model in AR, but here is centralized and we can test all the cases for it, therefore now the view model just calls this use case to decide if we need to enable cross domain search.
Dependencies (Optional)
A PR will follow in AR.
Needs releases with:
feat: support Proteus federation if MLS not supported by backend (WPB-14250) kalium#3126
GitHub link to other pull request
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.