fix(conversation): disable addMember on a one-on-one conversation with deleted account (WPB-10259) 🍒 🍒 #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
…isable-add-member-for-deleted-member-oneonone-cherry-pick-cherry-pick
MohamadJaara
approved these changes
Oct 7, 2024
…-conv-cherry-pick
…ber-to-deleted-accoutn-conv-cherry-pick' into fix/disable-add-member-for-deleted-member-oneonone-cherry-pick-cherry-pick # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/details/GroupConversationDetailsScreen.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/details/participants/GroupConversationParticipants.kt
8 tasks
|
|
Built wire-android-staging-compat-pr-3471.apk is available for download |
|
Built wire-android-dev-debug-pr-3471.apk is available for download |
yamilmedina
approved these changes
Oct 15, 2024
MohamadJaara
deleted the
fix/disable-add-member-for-deleted-member-oneonone-cherry-pick-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
…h deleted account
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When the other peer of a one-on-one conversation gets deleted, the backend changes the conversation to a group conversation. Android app was allowing the user to add member to that conversation and it was a confusing flow; in this PR we're preventing this.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.