Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conversation): disable addMember on a one-on-one conversation with deleted account (WPB-10259) 🍒 #3396

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 28, 2024

BugWPB-10259 [Android] : Duplicate 1:1 conversation - not showing one of the conv

This PR was automatically cherry-picked based on the following PR:

Original PR description:


…h deleted account


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When the other peer of a one-on-one conversation gets deleted, the backend changes the conversation to a group conversation. Android app was allowing the user to add member to that conversation and it was a confusing flow; in this PR we're preventing this.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/S labels Aug 28, 2024
Copy link

sonarcloud bot commented Sep 26, 2024

@MohamadJaara MohamadJaara added this pull request to the merge queue Sep 26, 2024
Merged via the queue into release/candidate with commit 1f6f2dd Sep 26, 2024
11 of 13 checks passed
@MohamadJaara MohamadJaara deleted the fix/disable-add-member-for-deleted-member-oneonone-cherry-pick branch September 26, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants