Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash on starting global analytics was not ready (WPB-11111) #3450

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: crash on starting global analytics was not ready (WPB-11111) #3450

merged 1 commit into from
Sep 17, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Sep 17, 2024 •
edited by github-actions bot
Loading

BugWPB-11111 [Android] crash caused by countly on activity startup

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

It can happen that Global analytics manager is being used before initialization

Causes (Optional)

lateinit var not ready

Solutions

Delay globalanalytics manager after coroutine scope and dependencies are assigned

Testing

Manually tested

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina changed the title fix: crash on starting analytics, global analytics not ready fix: crash on starting analytics, global analytics not ready (WPB-11111) Sep 17, 2024
@yamilmedina yamilmedina changed the title fix: crash on starting analytics, global analytics not ready (WPB-11111) fix: crash on starting global analytics was not ready (WPB-11111) Sep 17, 2024
@yamilmedina yamilmedina requested review from alexandreferris, MohamadJaara, a team, vitorhugods, mchenani and saleniuk and removed request for a team September 17, 2024 10:33
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3450.apk is available for download

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3450.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Sep 17, 2024
Merged via the queue into release/candidate with commit 6f735bc Sep 17, 2024
25 of 26 checks passed
@yamilmedina yamilmedina deleted the fix/countly-manager-init branch September 17, 2024 14:37
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
@yamilmedina @github-actions
fix: crash on starting global analytics was not ready (WPB-11111) (#3450
1a7c85d 
)
@github-actions github-actions bot mentioned this pull request Sep 17, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garzas Garzas Garzas approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

Assignees

@yamilmedina yamilmedina

Labels
echoes/initiative: product-metrics-in-countly Analytics and KPIs size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yamilmedina @alexandreferris @Garzas