Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash on starting global analytics was not ready (WPB-11111) 🍒 #3453

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 17, 2024

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-11111 [Android] crash caused by countly on activity startup


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

It can happen that Global analytics manager is being used before initialization

Causes (Optional)

lateinit var not ready

Solutions

Delay globalanalytics manager after coroutine scope and dependencies are assigned

Testing

Manually tested


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes/initiative: product-metrics-in-countly Analytics and KPIs size/XS labels Sep 17, 2024
Copy link

sonarcloud bot commented Sep 17, 2024

@yamilmedina yamilmedina added this pull request to the merge queue Sep 17, 2024
Copy link
Contributor Author

Built wire-android-staging-compat-pr-3453.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3453.apk is available for download

Merged via the queue into develop with commit f50eb68 Sep 17, 2024
12 checks passed
@yamilmedina yamilmedina deleted the fix/countly-manager-init-cherry-pick branch September 17, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes/initiative: product-metrics-in-countly Analytics and KPIs size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants