Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add gradle task to generate app version [WPB-7289] 🍒 #3358

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 22, 2024

This PR was automatically cherry-picked based on the following PR:

Original PR description:


StoryWPB-7289 [Android] adding version.txt when having a github release


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

the need to sync version code between diffrent stors

Solutions

create a gradle task that will generate the needed file and read the version code file when it is present

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/S labels Aug 22, 2024
…st-fdroid-version-cherry-pick

# Conflicts:
#	build-logic/plugins/src/main/kotlin/com/wire/android/gradle/version/Versionizer.kt
Copy link
Contributor Author

Built wire-android-staging-compat-pr-3358.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3358.apk is available for download

@yamilmedina yamilmedina enabled auto-merge August 30, 2024 09:13
Copy link

@yamilmedina yamilmedina added this pull request to the merge queue Aug 30, 2024
Copy link
Contributor Author

Built wire-android-staging-compat-pr-3358.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3358.apk is available for download

Merged via the queue into develop with commit 74c545c Aug 30, 2024
11 of 12 checks passed
@yamilmedina yamilmedina deleted the ci/test-fdroid-version-cherry-pick branch August 30, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants