ci: add gradle task to generate app version [WPB-7289] #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamadJaara
commented
Aug 21, 2024
| @@ -26,7 +27,15 @@ object AndroidSdk { | |||
| object AndroidApp { | |||
There was a problem hiding this comment.
this whole class need refactoring but i did not want to go deep into the rabbit hole, this way it will continue to work as before
MohamadJaara
requested review from
yamilmedina,
vitorhugods,
mchenani and
ohassine
MohamadJaara
changed the title
MohamadJaara
force-pushed
the
ci/test-fdroid-version
branch
from
1025f70
to
47e3b97
Compare
|
Built wire-android-staging-compat-pr-3355.apk is available for download |
mchenani
approved these changes
Aug 22, 2024
yamilmedina
approved these changes
Aug 22, 2024
|
|
Built wire-android-staging-compat-pr-3355.apk is available for download |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
the need to sync version code between diffrent stors
Solutions
create a gradle task that will generate the needed file and read the version code file when it is present
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.