Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use SFT for OneOnOne calls if the flag is true (WPB-7153) #3225

Merged
merged 9 commits into from
Jul 29, 2024
Merged

feat: use SFT for OneOnOne calls if the flag is true (WPB-7153) #3225

merged 9 commits into from
Jul 29, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Jul 23, 2024 •
edited by github-actions bot
Loading

StoryWPB-7153 [Android] Add flag for customer specific 1:1 calls in federated environment

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Fixing some breaking changes made on kalium side
wireapp/kalium#2893

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 23, 2024
@ohassine ohassine requested review from a team, typfel, alexandreferris, vitorhugods, Garzas and saleniuk and removed request for a team July 23, 2024 14:15
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-release-pr-3225.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3225.apk is available for download

@MohamadJaara
Copy link
Member

@ohassine this change should also be in the 4.6 branch

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-release-pr-3225.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3225.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-release-pr-3225.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3225.apk is available for download

@ohassine ohassine mentioned this pull request Jul 26, 2024
Merged
8 tasks
@ohassine ohassine mentioned this pull request Jul 29, 2024
Merged
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/candidate This PR
3acfed05ca26bc52841ad9424692ebf225afd052 179c081c629f0773cad5dd1f09ae71aaafc74696

Is this intentional?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexandreferris alexandreferris added this pull request to the merge queue Jul 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3225.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3225.apk is available for download

Merged via the queue into release/candidate with commit 7389744 Jul 29, 2024
12 of 13 checks passed
@alexandreferris alexandreferris deleted the use-sft-for-OneOnOne-calls-when-needed branch July 29, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreferris alexandreferris alexandreferris approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

Assignees

@ohassine ohassine

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ohassine @MohamadJaara @yamilmedina @alexandreferris