Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use SFT for one to one calls when needed (WPB-7153) #2893

Merged
merged 15 commits into from
Jul 26, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Jul 23, 2024

StoryWPB-7153 [Android] Add flag for customer specific 1:1 calls in federated environment


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

A follow up PR of #2889

It aims to use SFT for one on one calls if the correspondent flag is set to true.

Also changed the way to get conversation type, instead of getting all the conversation, we just get the type from db
Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 23, 2024
@ohassine ohassine changed the base branch from develop to release/candidate July 23, 2024 14:13
Copy link
Contributor

github-actions bot commented Jul 23, 2024

Test Results

2 965 tests   2 948 ✔️  1h 1m 3s ⏱️
       5 suites       17 💤
       5 files           0

Results for commit b344825.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jul 23, 2024

Datadog Report

Branch report: useSFTForOneToOneCalls-when-needed
Commit report: 8f6530f
Test service: kalium-jvm

✅ 0 Failed, 3025 Passed, 105 Skipped, 12.13s Total Time

Copy link

sonarcloud bot commented Jul 26, 2024

@MohamadJaara MohamadJaara enabled auto-merge (squash) July 26, 2024 07:43
@MohamadJaara MohamadJaara merged commit f4bcf01 into release/candidate Jul 26, 2024
21 checks passed
@MohamadJaara MohamadJaara deleted the useSFTForOneToOneCalls-when-needed branch July 26, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: XL type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants