chore(mls): unify MLS client identity models (WPB-9774) #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndroid-reloaded into fix/unify-mls-client-identity-models
Test Results857 tests 857 ✅ 8m 13s ⏱️ Results for commit 15dedbf. ♻️ This comment has been updated with latest results. |
mchenani
changed the title
…dels' into fix/unify-mls-client-identity-models
mchenani
requested review from
borichellow,
vitorhugods,
yamilmedina and
saleniuk
mchenani
changed the title
…ndroid-reloaded into fix/unify-mls-client-identity-models
MohamadJaara
approved these changes
Jul 18, 2024
vitorhugods
approved these changes
Jul 18, 2024
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
8 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
Signed-off-by: alexandreferris <[email protected]> Co-authored-by: alexandreferris <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
Signed-off-by: alexandreferris <[email protected]> Co-authored-by: alexandreferris <[email protected]>
8 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
) Signed-off-by: alexandreferris <[email protected]> Co-authored-by: Mojtaba Chenani <[email protected]> Co-authored-by: alexandreferris <[email protected]> Co-authored-by: Yamil Medina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
To fetch the MLSClientIdentity from CC we were mapping them in different models, due to different changes we needed more data to be exposed, we needed them to be unified and map all the available data from CC.
Issues
Hard to maintain different models
Due to maturity of CC now we have a rich and solid model we can map full object in Kalium and Android App.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
We need to test all E2EI features on this PR
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.