chore(mls): unify MLSClientIdentity models (WPB-9774) #2818

mchenani · 2024-06-18T12:33:23Z

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

To fetch the MLSClientIdentity from CC we were mapping them in different models, due to different changes we needed more data to be exposed, we needed them to be unified and map all the available data from CC.

Issues

Hard to maintain different models
Due to maturity of CC now we have a rich and solid model we can map full object in Kalium and Android App.

Needs releases with:
With AR

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

All E2EI features must work as before!

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

mchenani · 2024-06-18T12:42:55Z

...otlin/com/wire/kalium/logic/feature/e2ei/usecase/GetMembersE2EICertificateStatusesUseCase.kt

        mlsConversationRepository.getMembersIdentities(conversationId, userIds).fold(
            { mapOf() },
            {
                it.mapValues { (_, identities) ->
-                    identities.getUserCertificateStatus()
+                    // todo: we need to check the user name and details!


Unfortunately this was missed from the main code; I noticed it here! I don't want to mix the changes for this one in the PR [it's big already] so it's coming in another PR!

github-actions · 2024-06-18T12:44:41Z

Test Results

2 891 tests 2 873 ✔️ 3m 52s ⏱️
      7 suites     18 💤
      7 files       0 ❌

Results for commit 23a09d6.

♻️ This comment has been updated with latest results.

...src/commonTest/kotlin/com/wire/kalium/logic/feature/client/ObserveE2EIRequiredUseCaseTest.kt

datadog-wireapp · 2024-06-18T12:56:05Z

Datadog Report

All test runs 983e7a1 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Test Service View
`kalium-ios`	0	0	0	2768	123	1.58s	Link
`kalium-jvm`	0	0	0	2909	107	6.46s	Link

borichellow

great job! Now it looks much better and understendable :)

logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/ObserveE2EIRequiredUseCase.kt

…entity-models

codecov-commenter · 2024-06-26T08:55:46Z

Codecov Report

Attention: Patch coverage is 80.80808% with 19 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/android-cycle-4.6@c7792e3). Learn more about missing BASE report.

Additional details and impacted files

@@                     Coverage Diff                      @@
##             release/android-cycle-4.6    #2818   +/-   ##
============================================================
  Coverage                             ?   58.44%           
  Complexity                           ?        7           
============================================================
  Files                                ?     1184           
  Lines                                ?    46648           
  Branches                             ?     4437           
============================================================
  Hits                                 ?    27264           
  Misses                               ?    17406           
  Partials                             ?     1978

Files	Coverage Δ
...monMain/kotlin/com/wire/kalium/cryptography/IDs.kt	`89.58% <100.00%> (ø)`
.../data/conversation/DecryptedMessageBundleMapper.kt	`50.00% <100.00%> (ø)`
...gic/data/conversation/MLSConversationRepository.kt	`83.85% <100.00%> (ø)`
.../kotlin/com/wire/kalium/logic/di/MapperProvider.kt	`91.66% <ø> (ø)`
.../feature/e2ei/usecase/GetE2EICertificateUseCase.kt	`100.00% <100.00%> (ø)`
.../e2ei/usecase/GetUserE2EIAllCertificatesUseCase.kt	`100.00% <100.00%> (ø)`
...ture/e2ei/usecase/GetUserE2EICertificateUseCase.kt	`100.00% <100.00%> (ø)`
...m/logic/feature/user/ObserveE2EIRequiredUseCase.kt	`97.72% <100.00%> (ø)`
...in/kotlin/com/wire/kalium/logic/data/id/PlainId.kt	`0.00% <0.00%> (ø)`
...otlin/com/wire/kalium/logic/data/id/QualifiedId.kt	`60.86% <66.66%> (ø)`
... and 6 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7792e3...23a09d6. Read the comment docs.

…entity-models

…p/kalium into fix/unify-mls-client-identity-models

datadog-wireapp · 2024-07-16T07:44:44Z

Datadog Report

All test runs b456f95 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Test Service View
`kalium-ios`	0	0	0	2778	123	1.31s	Link
`kalium-jvm`	0	0	0	2919	107	5.3s	Link

…p/kalium into fix/unify-mls-client-identity-models

sonarcloud · 2024-07-17T12:24:09Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

* chore: refactor identity models * fix tests * user correct clientId and Handle in MLSClientIdentity object * clean mapping object checker * fix formatting and remove one line un-used code --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> (cherry picked from commit 8f000c0)

…#2902) * chore: refactor identity models * fix tests * user correct clientId and Handle in MLSClientIdentity object * clean mapping object checker * fix formatting and remove one line un-used code --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> (cherry picked from commit 8f000c0) Co-authored-by: Mojtaba Chenani <[email protected]> Co-authored-by: Yamil Medina <[email protected]>

mchenani added 2 commits June 12, 2024 11:07

chore: refactor identity models

47f2549

fix tests

6fec651

github-actions bot assigned mchenani Jun 18, 2024

github-actions bot added 🚨 Potential breaking changes 👕 size: XL type: chore 🧹 labels Jun 18, 2024

mchenani requested review from borichellow, MohamadJaara, yamilmedina and vitorhugods June 18, 2024 12:35

mchenani commented Jun 18, 2024

View reviewed changes

mchenani mentioned this pull request Jun 18, 2024

chore(mls): unify MLS client identity models (WPB-9774) wireapp/wire-android#3107

Merged

8 tasks

mchenani commented Jun 18, 2024

View reviewed changes

...src/commonTest/kotlin/com/wire/kalium/logic/feature/client/ObserveE2EIRequiredUseCaseTest.kt Outdated Show resolved Hide resolved

mchenani marked this pull request as ready for review June 19, 2024 07:59

user correct clientId and Handle in MLSClientIdentity object

929bbb0

github-actions bot added 👕 size: XXL and removed 👕 size: XL labels Jun 20, 2024

clean mapping object checker

24d9512

mchenani changed the title ~~chore(mls): unify MLSClientIdentity models~~ chore(mls): unify MLSClientIdentity models (WPB-9774) Jun 20, 2024

borichellow approved these changes Jun 24, 2024

View reviewed changes

logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/ObserveE2EIRequiredUseCase.kt Outdated Show resolved Hide resolved

logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/ObserveE2EIRequiredUseCase.kt Outdated Show resolved Hide resolved

vitorhugods approved these changes Jun 24, 2024

View reviewed changes

Merge branch 'release/android-cycle-4.6' into fix/unify-mls-client-id…

b3428f8

…entity-models

mchenani and others added 5 commits June 26, 2024 11:38

fix formatting and remove one line un-used code

fccadcb

Merge branch 'release/android-cycle-4.6' into fix/unify-mls-client-id…

6e48d22

…entity-models

Merge branch 'release/android-cycle-4.6' into fix/unify-mls-client-id…

72a4a09

…entity-models

Merge branch 'release/android-cycle-4.6' into fix/unify-mls-client-id…

1f6b0cc

…entity-models

Merge branch 'release/android-cycle-4.6' of https://github.com/wireap…

d793d17

…p/kalium into fix/unify-mls-client-identity-models

Merge branch 'release/android-cycle-4.6' of https://github.com/wireap…

23a09d6

…p/kalium into fix/unify-mls-client-identity-models

mchenani enabled auto-merge (squash) July 17, 2024 15:32

mchenani disabled auto-merge July 17, 2024 15:32

mchenani merged commit 8f000c0 into release/android-cycle-4.6 Jul 18, 2024
19 checks passed

mchenani deleted the fix/unify-mls-client-identity-models branch July 18, 2024 07:21

github-actions bot mentioned this pull request Jul 18, 2024

chore(mls): unify MLSClientIdentity models (WPB-9774) 🍒 #2885

Closed

8 tasks

echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Jul 18, 2024

mchenani mentioned this pull request Jul 25, 2024

chore(mls): unify MLSClientIdentity models (WPB-9774) 🍒 #2885 #2900

Merged

8 tasks

github-actions bot mentioned this pull request Jul 25, 2024

chore(mls): unify MLSClientIdentity models (WPB-9774) 🍒 #2885 🍒 #2902

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(mls): unify MLSClientIdentity models (WPB-9774) #2818

chore(mls): unify MLSClientIdentity models (WPB-9774) #2818

mchenani commented Jun 18, 2024

mchenani Jun 18, 2024

github-actions bot commented Jun 18, 2024 •

edited

Loading

datadog-wireapp bot commented Jun 18, 2024 •

edited

Loading

borichellow left a comment

codecov-commenter commented Jun 26, 2024 •

edited

Loading

datadog-wireapp bot commented Jul 16, 2024 •

edited

Loading

sonarcloud bot commented Jul 17, 2024

chore(mls): unify MLSClientIdentity models (WPB-9774) #2818

chore(mls): unify MLSClientIdentity models (WPB-9774) #2818

Conversation

mchenani commented Jun 18, 2024

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Testing

Test Coverage (Optional)

How to Test

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

mchenani Jun 18, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 18, 2024 • edited Loading

Test Results

datadog-wireapp bot commented Jun 18, 2024 • edited Loading

Datadog Report

borichellow left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jun 26, 2024 • edited Loading

Codecov Report

datadog-wireapp bot commented Jul 16, 2024 • edited Loading

Datadog Report

sonarcloud bot commented Jul 17, 2024

Quality Gate passed

github-actions bot commented Jun 18, 2024 •

edited

Loading

datadog-wireapp bot commented Jun 18, 2024 •

edited

Loading

codecov-commenter commented Jun 26, 2024 •

edited

Loading

datadog-wireapp bot commented Jul 16, 2024 •

edited

Loading