Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Get Current Analytics Tracking Identifier (WPB-10600) 🍒 #2951

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 15, 2024

TaskWPB-10600 [Android] Show countly details in debug settings

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There was no possible way of getting current analytics tracking identifier directly (only existing way is a observer/flow)

Causes (Optional)

Not implemented

Solutions

Implement usecase and add tests

Dependencies (Optional)

Needs releases with:

AR PR will follow

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

There is no way to test this PR for now, as it will be used in conjunction with AR

* feat: add get current analytics tracking identifier usecase

* feat: add dummy server config for tests
@alexandreferris alexandreferris requested review from a team, typfel, yamilmedina, borichellow, MohamadJaara and mchenani and removed request for a team August 15, 2024 12:39
Copy link

Copy link
Contributor Author

github-actions bot commented Aug 15, 2024

Test Results

3 155 tests  +1   3 050 ✔️ +1   3m 41s ⏱️ +23s
   541 suites +1      105 💤 ±0 
   541 files   +1          0 ±0 

Results for commit f7f2b4f. ± Comparison against base commit f755a71.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

🐰Bencher

ReportThu, August 15, 2024 at 12:56:24 UTC
Projectkalium
Branchfeat/analytics_get_tracking_id-cherry-pick
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)692,853.05
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)542,429,888.52
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)930,406,818.83
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,083,898.78

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@alexandreferris alexandreferris added this pull request to the merge queue Aug 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.48%. Comparing base (f755a71) to head (f7f2b4f).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2951      +/-   ##
===========================================
+ Coverage    52.47%   52.48%   +0.01%     
===========================================
  Files         1290     1291       +1     
  Lines        49580    49593      +13     
  Branches      4604     4604              
===========================================
+ Hits         26018    26031      +13     
  Misses       21717    21717              
  Partials      1845     1845              
Files Coverage Δ
.../kalium/logic/configuration/server/ServerConfig.kt 65.56% <100.00%> (+1.49%) ⬆️
...cs/GetCurrentAnalyticsTrackingIdentifierUseCase.kt 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f755a71...f7f2b4f. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/analytics_get_tracking_id-cherry-pick
Commit report: 0c94e86
Test service: kalium-jvm

✅ 0 Failed, 3050 Passed, 105 Skipped, 14.98s Total Time

Merged via the queue into develop with commit ad1bbe2 Aug 15, 2024
22 checks passed
@alexandreferris alexandreferris deleted the feat/analytics_get_tracking_id-cherry-pick branch August 15, 2024 13:28
@echoes-hq echoes-hq bot added echoes/initiative: product-metrics-in-countly Analytics and KPIs echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes/initiative: product-metrics-in-countly Analytics and KPIs echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants