Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Get Current Analytics Tracking Identifier (WPB-10600) #2949

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Aug 14, 2024

TaskWPB-10600 [Android] Show countly details in debug settings


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There was no possible way of getting current analytics tracking identifier directly (only existing way is a observer/flow)

Causes (Optional)

Not implemented

Solutions

Implement usecase and add tests

Dependencies (Optional)

Needs releases with:

AR PR will follow

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

There is no way to test this PR for now, as it will be used in conjunction with AR

Copy link
Contributor

github-actions bot commented Aug 14, 2024

Test Results

3 168 tests  +1   3 063 ✔️ +1   3m 48s ⏱️ +2s
   543 suites +1      105 💤 ±0 
   543 files   +1          0 ±0 

Results for commit b86814a. ± Comparison against base commit 58d7ee8.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Aug 14, 2024

Datadog Report

Branch report: feat/analytics_get_tracking_id
Commit report: 8e4675e
Test service: kalium-jvm

✅ 0 Failed, 3063 Passed, 105 Skipped, 15.32s Total Time

Copy link

sonarcloud bot commented Aug 14, 2024

Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small question :)

@alexandreferris alexandreferris added this pull request to the merge queue Aug 15, 2024
Merged via the queue into release/candidate with commit faff60a Aug 15, 2024
22 checks passed
@alexandreferris alexandreferris deleted the feat/analytics_get_tracking_id branch August 15, 2024 12:01
github-actions bot pushed a commit that referenced this pull request Aug 15, 2024
* feat: add get current analytics tracking identifier usecase

* feat: add dummy server config for tests
github-merge-queue bot pushed a commit that referenced this pull request Aug 15, 2024
* feat: Get Current Analytics Tracking Identifier (WPB-10600) (#2949)

* feat: add get current analytics tracking identifier usecase

* feat: add dummy server config for tests

* empty trigger commit

---------

Co-authored-by: Alexandre Ferris <[email protected]>
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: product-metrics-in-countly Analytics and KPIs echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants