Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to choose between underscored or hyphenated class names. #13

Merged
merged 2 commits into from
Jan 29, 2015

Conversation

jsyeo
Copy link
Contributor

@jsyeo jsyeo commented Jan 29, 2015

lol

scss-lint prefers hyphenated selectors by default. It is also recommended by sass to use hyphenated selectors. We should allow users to choose whether they want hyphenated or underscored selectors.

@winston
Copy link
Owner

winston commented Jan 29, 2015

👏 Very nice!

Actually have been thinking of doing the hyphenated selectors for a while, and am even considering making the hyphenated selectors the default. Thanks!

Merging this first, and will push a new version later.

You can reference this master branch first. :)

winston added a commit that referenced this pull request Jan 29, 2015
Add config to choose between underscored or hyphenated class names.
@winston winston merged commit 5d21500 into winston:master Jan 29, 2015
@jsyeo
Copy link
Contributor Author

jsyeo commented Jan 29, 2015

making the hyphenated selectors the default.

😅 I wanted to do that but I was afraid that I'll break someone's app.

@winston
Copy link
Owner

winston commented Jan 29, 2015

I'll break someone's app.

If we do that then it will definitely be a major version release, to v4. But this is good for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants