Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable scss checks on hound #83

Merged
merged 3 commits into from
Jan 29, 2015
Merged

Conversation

jsyeo
Copy link
Contributor

@jsyeo jsyeo commented Jan 28, 2015

lol

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.76% when pulling b1257a6 on jsyeo:jsyeo-enable-scss into 007e7da on Coursemology:master.

@lowjoel
Copy link
Member

lowjoel commented Jan 29, 2015

can you help remove the linter from Travis, and then check that they've got sane SCSS defaults (a la our .unhound.yml...)

@lowjoel
Copy link
Member

lowjoel commented Jan 29, 2015

And also from #81, wrt https://github.com/causes/scss-lint/blob/master/config/default.yml, there's some configuration options for naming.

We might want to change this to follow Winston's rails_utils (controller is underscored), selectors are dasherised. So a regex for valid identifiers would be in order.

@jsyeo
Copy link
Contributor Author

jsyeo commented Jan 29, 2015

We might want to change this to follow Winston's rails_utils (controller is underscored), selectors are dasherised

I am not so sure about using underscored selectors in our css. 😕 Nevertheless, I sent in a PR to rails_utils 👉 winston/rails_utils#13

@jsyeo
Copy link
Contributor Author

jsyeo commented Jan 29, 2015

check that they've got sane SCSS defaults (a la our .unhound.yml...)

Seems sane to me.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.76% when pulling a7e0b4f on jsyeo:jsyeo-enable-scss into 007e7da on Coursemology:master.

lowjoel added a commit that referenced this pull request Jan 29, 2015
@lowjoel lowjoel merged commit 01c7d4f into Coursemology:master Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants