chore: update dev env to node20 and npm9 #2892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly I was mistaken, the root issue still hasn't been addressed. bundled deps of bundled deps still are being left out. Since I was hoping this would be a quick win, I'll just close this 😢 |
|
@MarkMcCulloh Do ya know if there a bug upstream in Node that we can report? or is there a chance this is intended behavior? 🤔 |
|
I believe this is the issue npm/cli#6251 It may not be intended, but I also think the npm ecosystem is generally trying to move away from bundled dependencies, so it doesn't seem like they're rushing to fix it. There is a similar longstanding issue when using bundledDeps with workspaces npm/cli#3466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1553
I've previously attempted this update and there was at least 1 major bug in npm that made it not work. I was curious today and wanted to check if it was fixed (or we're bypassing it with the new compiler package), and yeah everything seems to work (pending this PR workflow succeeding of course).
While I was there I figured it made sense to update node as well. node20 will soon be lts, might as well have the latest-and-greatest.
Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.