Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use npm 9 in our CI/CD #1553

Closed
Chriscbr opened this issue Feb 15, 2023 · 3 comments
Closed

Use npm 9 in our CI/CD #1553

Chriscbr opened this issue Feb 15, 2023 · 3 comments
Assignees
@MarkMcCulloh
Labels
✨ enhancement New feature or request

Comments

@Chriscbr
Copy link
Contributor

This change should not affect how consumers use Wing
@Chriscbr Chriscbr added the ✨ enhancement New feature or request label Feb 15, 2023
@monadabot monadabot added this to Wing Feb 15, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New - not properly defined in Wing Feb 15, 2023
@staycoolcall911 staycoolcall911 moved this from 🆕 New - not properly defined to 🤝 Backlog - handoff to owners in Wing Feb 16, 2023
@MarkMcCulloh MarkMcCulloh self-assigned this Feb 20, 2023
@MarkMcCulloh
Copy link
Contributor

MarkMcCulloh commented Feb 21, 2023 •
edited
Loading

Explored this issue in #1603 and found that npm pack did not include bundled dependencies in the resulting @winglang/sdk tarball with npm 9, causing missing @aws-sdk/* packages failing during preflight.

@MarkMcCulloh MarkMcCulloh removed their assignment Feb 21, 2023
@MarkMcCulloh MarkMcCulloh mentioned this issue Feb 21, 2023
Closed
@github-actions
Copy link

Hi,

This issue hasn't seen activity in 60 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

@github-actions github-actions bot added the Stale label Apr 27, 2023
@MarkMcCulloh MarkMcCulloh mentioned this issue Jun 12, 2023
Closed
5 tasks
@MarkMcCulloh
Copy link
Contributor

Closing, moved to pnpm

@github-project-automation github-project-automation bot moved this from 🤝 Backlog - handoff to owners to ✅ Done in Wing Sep 27, 2023
@MarkMcCulloh MarkMcCulloh self-assigned this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkMcCulloh MarkMcCulloh

Labels
✨ enhancement New feature or request
Projects
Wing
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update dev env to node20 and npm9 winglang/wing
3 participants
@MarkMcCulloh @Chriscbr @staycoolcall911