Remove deprecated function & Cleanup #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is needed but should be done consistently over all views. At the moment we have a split between this format and what you are proposing here. I think that it doesn't make sense to feature creep my PR with this. But I definitely think we should do this over all the views in a separate PR! |
wilsonge
pushed a commit
that referenced
this pull request
Jun 3, 2017
* codestyle * code style * codestyle * codestyle * codestyle * thanks @wojsmol * corrections - thanks @Quy * corrections - thanks @Quy * oops * make @Quy happy * Update article.xml * Remove space * Update config.xml (#14) * Update filter.xml (#15) * Update config.xml (#16) * Update profile.xml (#17) * Update application.xml (#18) * Update article.xml (#19) * Update filter_articles.xml (#20) * Update config.xml (#24) * Update config.xml (#23) * Update filter_fields.xml (#22) * Update filter_featured.xml (#21) * Update override.xml (#25) * Update config.xml * Update config.xml (#26) * Update itemadmin_alias.xml (#30) * Update itemadmin.xml (#29) * Update item.xml (#27) * Update item_alias.xml (#28) * Update itemadmin_url.xml (#31) * Update module.xml (#32) * Update plugin.xml (#33) * Update config.xml (#34) * Update link.xml (#35) * Update config.xml (#36) * Update style.xml (#38) * Update config.xml (#37) * Update note.xml (#42) * Update group.xml (#41) * Update filter_debuggroup.xml (#40) * Update config.xml (#39) * corrections for @andrepereiradasilva * gotya
wilsonge
pushed a commit
that referenced
this pull request
Aug 30, 2017
* update to the latest news on Joomla 4.0 * Change markup (#29)
wilsonge
pushed a commit
that referenced
this pull request
May 12, 2018
* Corrected the code style. 1. Replaced the wrong class doc comment with an example format in \administrator\components\com_workflow\Helper\WorkflowHelper.php. Change the example format with the relevant content. 2. Rest I corrected the alignment. * Changes return replace the class doc exmple format with correct one :)
wilsonge
added a commit
that referenced
this pull request
Jul 10, 2018
wilsonge
pushed a commit
that referenced
this pull request
Sep 10, 2018
Improve export logs + purge thanks @joomdonation
laoneo
added a commit
that referenced
this pull request
Jun 28, 2023
* Convert the content plugins to service providers * functions * namespaces * doc * get application from plugin (#29) * get application from plugin * Revert pagenavigation --------- Co-authored-by: heelc29 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for joomla#12296
Summary of Changes
always use $this->{var} and not {var} && $this->{var}
Testing Instructions
Code review
Documentation Changes Required