Change installer.php to be able to handle using of old db driver and sql statements #25
Conversation
|
I close this PR so I can delete my branch for it, but maybe it would make sense to add missing query downgrade to the libraries/cms/installer/installer.php (but not use local functions as I did in this PR for testing purposes), and also change back the administrator/components/com_admin/sql/updates/mysql/3.5.0-2016-02-26.sql as I did here. Let me know your opinion pls., and if necessary I make a PR. |
|
I agree with both - just shove them in with one PR. |
|
OK, will do so. What about the input filter thing, strip off if not converted to utf8mb4 and not if not supported but maybe not converted yet? Or maybe better: Strip off either if not converted to utf8mb4 yet (status <> 3) or if utf8mb4 not supported (regardless of status, so we cover the crazy migration from new converted to old not supported db where pople just replace "utf8mb4" by "utf8" in their dump and not change the "converted" status in the new table? (such migration we should maybe forbid because it would mean data loss when having used text or varchar columns close to their max length?) Who shall make the input filter PR? You? Or me? Maybe you would be better than me in finding suitable test instructuctions? |
|
I can do the input filter after work this evening (or maybe even lunch time) :) Feeling much better today |
|
Good to hear |
* codestyle * code style * codestyle * codestyle * codestyle * thanks @wojsmol * corrections - thanks @Quy * corrections - thanks @Quy * oops * make @Quy happy * Update article.xml * Remove space * Update config.xml (#14) * Update filter.xml (#15) * Update config.xml (#16) * Update profile.xml (#17) * Update application.xml (#18) * Update article.xml (#19) * Update filter_articles.xml (#20) * Update config.xml (#24) * Update config.xml (#23) * Update filter_fields.xml (#22) * Update filter_featured.xml (#21) * Update override.xml (#25) * Update config.xml * Update config.xml (#26) * Update itemadmin_alias.xml (#30) * Update itemadmin.xml (#29) * Update item.xml (#27) * Update item_alias.xml (#28) * Update itemadmin_url.xml (#31) * Update module.xml (#32) * Update plugin.xml (#33) * Update config.xml (#34) * Update link.xml (#35) * Update config.xml (#36) * Update style.xml (#38) * Update config.xml (#37) * Update note.xml (#42) * Update group.xml (#41) * Update filter_debuggroup.xml (#40) * Update config.xml (#39) * corrections for @andrepereiradasilva * gotya
Clean up UserlogsHelper thanks @joomdonation
Summary of Changes
I've experimented here a bit with the query downgrade and so on in installer.php and seen there was also a problem with comment lines before statements, and so I added stuff from script.php locally there, too, and added query downgrade wherever necessary now or in future.
The result now is that all works well for the update component, but the extension installer seems to fail because it is running the old installer.php.
Can this be?
You can use this PR here and merge, or you can leave it open just for documentation / discussion purpose.
Maybe not all the changes I made were necessary, e.g. the local versions of functions like the query downgrade or the utf8mb4 support check.
And so maybe not merge it but use it as base for later changes.
Let me know what you think when you find some time.