Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-526] Removal of the workaround for this issue. #214

Merged
merged 1 commit into from
Nov 21, 2022
Merged

[WFCORE-526] Removal of the workaround for this issue. #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## 2.0.0 (not yet released)

- removed the workaround for WFCORE-526

## 2.0.0-Alpha.3

- added support for WildFly 21 - WildFly 24
Expand Down
33 changes: 0 additions & 33 deletions core/src/main/java/org/jboss/as/cli/impl/WorkaroundForWFCORE526_CommandContextImpl.java
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions core/src/main/java/org/wildfly/extras/creaper/core/online/OnlineManagementClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import org.jboss.as.cli.CliInitializationException;
import org.jboss.as.cli.CommandContext;
import org.jboss.as.cli.CommandFormatException;
import org.jboss.as.cli.impl.WorkaroundForWFCORE526_CommandContextImpl;
import org.jboss.as.cli.impl.CommandContextFactoryImpl;
import org.jboss.as.controller.client.ModelControllerClient;
import org.jboss.as.controller.client.Operation;
import org.jboss.dmr.ModelNode;
Expand Down Expand Up @@ -44,7 +44,7 @@ private void connect() throws IOException {
try {
fakeJbossCliConfigToAvoidWarning();

this.cliContext = new WorkaroundForWFCORE526_CommandContextImpl(options.host, options.port);
this.cliContext = new CommandContextFactoryImpl().newCommandContext();
cliContext.setSilent(true); // CLI shouldn't print messages to the console directly; proper logging is fine
cliContext.bindClient(client);
} catch (CliInitializationException e) {
Expand Down