Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-526] Removal of the workaround for this issue. #214

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

jstourac
Copy link
Collaborator

Let's remove the workaround for the [1] since we don't need it anymore since we support only WildFly 10+ now.

[1] https://issues.redhat.com/browse/WFCORE-526

@jstourac jstourac requested a review from simkam November 15, 2022 10:45
@simkam
Copy link
Collaborator

simkam commented Nov 16, 2022

please rebase after #215 is merged

@jstourac
Copy link
Collaborator Author

I've pushed manually the master -> main change in a separate commit until #215 is done so that we have some results. Once it's merged, I'll rebase this one.

Let's remove the workaround for the [1] since we don't need it anymore
since we support only WildFly 10+ now.

[1] https://issues.redhat.com/browse/WFCORE-526
@jstourac
Copy link
Collaborator Author

jstourac commented Nov 21, 2022

I've pushed manually the master -> main change in a separate commit until #215 is done so that we have some results. Once it's merged, I'll rebase this one.

Okay, so CI tests passed just fine. I have rebased with your changes. Haven't actually tried manually with any recent JBoss EAP/WildFly release yet.

@simkam simkam merged commit 5857bea into wildfly-extras:main Nov 21, 2022
@jstourac jstourac deleted the workaroundRemove branch November 21, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants