add WildFly 25 #210
Merged
add WildFly 25 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
…WildFly 25 and above legacy security was removed in WildFly 25
Merged
jstourac
reviewed
Jan 5, 2023
| = ManagementClient.online(OnlineOptions.standalone().localDefault().build()).version(); | ||
| Assume.assumeFalse("Legacy security was removed in WildFly 25.", | ||
| serverVersion.greaterThanOrEqualTo(ServerVersion.VERSION_18_0_0)); | ||
| } |
There was a problem hiding this comment.
Just a proposal - wouldn't be better to create some common function for this and use it in all relevant places instead of having the very same code on multiple places? 👼
There was a problem hiding this comment.
I was thinking about it but in the end, I followed the same convention as it is in elytron commands, there is a similar check in every elytron command.
jstourac
reviewed
Jan 5, 2023
| @@ -43,6 +44,10 @@ private AddAuthorizationModule(Builder builder) { | |||
| @Override | |||
| public void apply(OnlineCommandContext ctx) throws CliException, CommandFailedException, IOException, | |||
| TimeoutException, InterruptedException { | |||
| if (ctx.version.greaterThanOrEqualTo(ServerVersion.VERSION_18_0_0)) { | |||
| throw new AssertionError("Legacy security was removed in WildFly 25."); | |||
| } | |||
There was a problem hiding this comment.
Again, having some common function would be probably nicer. But I don't insist.
|
Just two comments but LGTM otherwise :) |
jstourac
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intentionally adding only a single WF version per PR to leverage GH CI
depends on #206, #207, #208 and #209