add WildFly 23 #208
Merged
add WildFly 23 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
simkam
force-pushed
the
wf23
branch
2 times, most recently
from
0ff33ff to
29477f5
Compare
jstourac
reviewed
Jun 17, 2022
| administration.reloadIfRequired(); | ||
| ops.removeIfExists(TMP_PATH_ADDRESS); |
There was a problem hiding this comment.
I'm thinking that we should have another administration.reloadIfRequired() call here again to finish the cleanup task?
There was a problem hiding this comment.
well, technically we should but since the deleting operation over the /path shouldn't require that, we can probably leave it as is now...
jstourac
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intentionally adding only a single WF version per PR to leverage GH CI
depends on #206 and #207