Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce no-visibility, deprecate no-show, no-hide, no-toggle #166

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Introduce no-visibility, deprecate no-show, no-hide, no-toggle #166

merged 2 commits into from
Oct 16, 2019

Conversation

edg2s
Copy link
Member

@edg2s edg2s commented Oct 16, 2019

See #163

jdforrester
jdforrester reviewed Oct 16, 2019
View reviewed changes
README.md Show resolved Hide resolved
jdforrester
jdforrester previously approved these changes Oct 16, 2019
View reviewed changes
@jdforrester
Copy link
Member 

/home/travis/build/wikimedia/eslint-plugin-no-jquery/test-all/methods.js
  139:1  error  $.hide is not allowed    rulesdir/no-visibility
  197:1  error  $.show is not allowed    rulesdir/no-visibility
  209:1  error  $.toggle is not allowed  rulesdir/no-visibility

Fun. Test-all is working.

@jdforrester jdforrester merged commit 8ee107e into master Oct 16, 2019
@jdforrester jdforrester deleted the no-visibility branch October 16, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdforrester jdforrester jdforrester approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edg2s @jdforrester