Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group rules more sensibly #163

Open
edg2s opened this issue Oct 16, 2019 · 0 comments
Open

Group rules more sensibly #163

edg2s opened this issue Oct 16, 2019 · 0 comments

Comments

@edg2s
Copy link
Member

edg2s commented Oct 16, 2019 •
edited
Loading

Some rules disallow related methods:

  • no-wrap: wrap, unwrap, wrapAll, wrapInner
  • no-ajax: ajax, get, getJSON, getScript, post

Some are broken up to fairly useless separate rules

  • no-bind, no-unbind
  • no-show, no-hide, no-toggle

Individual rules should be deprecated in favour of functional groupings.

Per ESLint policy, deprecated rules need never been removed. If there is demand in future to break up these groups, that can be done when a use case is presented c.f. adding granular options to no-animate and no-extend.

Another use case for separate rules is when particular methods are deprecated in jQuery, e.g. no-unique must remain separate to no-unique-sort (were it to be created).
@edg2s edg2s mentioned this issue Oct 16, 2019
Open
94 tasks
edg2s added a commit that referenced this issue Oct 16, 2019
@edg2s
Introduce no-visibility, deprecate no-show, no-hide, no-toggle
aa7bd9a 
See #163
edg2s added a commit that referenced this issue Oct 16, 2019
@edg2s
Introduce no-visibility, deprecate no-show, no-hide, no-toggle
080dcca 
See #163
@edg2s edg2s mentioned this issue Oct 16, 2019
Merged
edg2s added a commit that referenced this issue Oct 16, 2019
@edg2s
Introduce no-visibility, deprecate no-show, no-hide, no-toggle
5e7052c 
See #163
jdforrester pushed a commit that referenced this issue Oct 16, 2019
@edg2s @jdforrester
Introduce no-visibility, deprecate no-show, no-hide, no-toggle (
8ee107e 
#166)

* Introduce `no-visibility`, deprecate `no-show`, `no-hide`, `no-toggle`

See #163

* Update test-all/methods.js
edg2s added a commit that referenced this issue Dec 17, 2019
@edg2s
Merge event unbinding rules in binding rules and deprecate
01e9494 
Merges:
* no-die -> no-live
* no-unbind -> no-bind
* no-undelegate -> no-delegate

Part of #163
@edg2s edg2s mentioned this issue Dec 17, 2019
Merged
jdforrester pushed a commit that referenced this issue Dec 17, 2019
@edg2s @jdforrester
Merge event unbinding rules in binding rules and deprecate (#186)
faf961d 
Merges:
* no-die -> no-live
* no-unbind -> no-bind
* no-undelegate -> no-delegate

Part of #163
edg2s added a commit that referenced this issue Mar 16, 2020
@edg2s
Follow-up #186: Actually merge no-undelegate into no-delegate
973bf5b 
Part of #163
@edg2s edg2s mentioned this issue Mar 16, 2020
Merged
jdforrester added a commit that referenced this issue Mar 16, 2020
@edg2s @jdforrester
Follow-up #186: Actually merge no-undelegate into no-delegate (#193)
08c0f6a 
Part of #163

Co-authored-by: James Forrester <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edg2s