-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 175: Plot identity vs coverage scatter plot #319
Conversation
`fig.supxlabel()`, et cetera threw an error with python 3.6
Also change label commands to use the `set` versions. Trying to find commands that work in `matplotlib 3.3.4` which is used by `python 3.6`.
@widdowquinn Tests on this are now failing for a reason unrelated to the code. See Issue #330 for details. |
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 75.85% 76.12% +0.27%
==========================================
Files 52 52
Lines 3342 3380 +38
==========================================
+ Hits 2535 2573 +38
Misses 807 807 |
combined[matname1] = dfr1.values.flatten() | ||
combined[matname2] = dfr2.values.flatten() | ||
|
||
# Add lable information, if available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that label info will end up being incorporated here. Labels apply to single genomes, not pairwise comparisons. Could just delete this commented-out section for now. We can discuss ideas for colouring points on the plot elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please merge. We should think of ways to indicate colour/regions on the plot that could be helpful to the user (e.g. "same species"/"same genus" etc.).
Plots an identity vs coverage scatter plot.
Closes #175. (Maybe.)
Documentation has not been added because the file it would go in is in #305, which has not yet been merged.
Type of change
(The relevant documentation update is dependent upon #305, though.)
Action Checklist
pyani
repository under your own account (please allow write access for repository maintainers)CONTRIBUTING.md
)pytest -v
non-passing code will not be mergedorigin/master
flake8
andblack
before submissionPull requests
section in thepyani
repository