Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 175: Plot identity vs coverage scatter plot #319

Merged
merged 9 commits into from
Sep 8, 2021
Merged

Conversation

baileythegreen
Copy link
Contributor

Plots an identity vs coverage scatter plot.
Closes #175. (Maybe.)

Documentation has not been added because the file it would go in is in #305, which has not yet been merged.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update
  • This is a documentation update

(The relevant documentation update is dependent upon #305, though.)

Action Checklist

  • Work on a single issue/concept (if there are multiple separate issues to address, please use a separate pull request for each)
  • Fork the pyani repository under your own account (please allow write access for repository maintainers)
  • Set up an appropriate development environment (please see CONTRIBUTING.md)
  • Create a new branch with a short, descriptive name
  • Work on this branch
    • style guidelines have been followed
    • new code is commented, especially in hard-to-understand areas
    • corresponding changes to documentation have been made
    • tests for the change have been added that demonstrate the fix or feature works
  • Test locally with pytest -v non-passing code will not be merged
  • Rebase against origin/master
  • Check changes with flake8 and black before submission
  • Commit branch
  • Submit pull request, describing the content and intent of the pull request
  • Request a code review
  • Continue the discussion at Pull requests section in the pyani repository

@baileythegreen baileythegreen added enhancement something we'd like pyani to do that it doesn't already interface issues related to how the user tells pyani to do something visualisation issues relating to plot outputs labels Jul 29, 2021
@baileythegreen baileythegreen changed the title Issue 175 Issue 175: Plot identity vs coverage scatter plot Aug 10, 2021
Also change label commands to use the `set` versions. Trying to find 
commands that work in `matplotlib 3.3.4` which is used by `python 3.6`.
@baileythegreen
Copy link
Contributor Author

@widdowquinn Tests on this are now failing for a reason unrelated to the code. See Issue #330 for details.

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #319 (30e5c5f) into master (9435a5e) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   75.85%   76.12%   +0.27%     
==========================================
  Files          52       52              
  Lines        3342     3380      +38     
==========================================
+ Hits         2535     2573      +38     
  Misses        807      807              

combined[matname1] = dfr1.values.flatten()
combined[matname2] = dfr2.values.flatten()

# Add lable information, if available
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that label info will end up being incorporated here. Labels apply to single genomes, not pairwise comparisons. Could just delete this commented-out section for now. We can discuss ideas for colouring points on the plot elsewhere.

Copy link
Owner

@widdowquinn widdowquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please merge. We should think of ways to indicate colour/regions on the plot that could be helpful to the user (e.g. "same species"/"same genus" etc.).

@widdowquinn widdowquinn merged commit c4aa68b into master Sep 8, 2021
@baileythegreen baileythegreen deleted the issue_175 branch May 24, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement something we'd like pyani to do that it doesn't already interface issues related to how the user tells pyani to do something visualisation issues relating to plot outputs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coverage vs ANI output to pyani plot
2 participants