Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API symmetry: add ipaddr.IPv4.prototype.toNormalizedString method #67

Closed
JamesMGreene opened this issue Aug 18, 2017 · 3 comments
Closed

API symmetry: add ipaddr.IPv4.prototype.toNormalizedString method #67

JamesMGreene opened this issue Aug 18, 2017 · 3 comments

Comments

@JamesMGreene
Copy link
Contributor

For API symmetry, it would be nice to add a ipaddr.IPv4.prototype.toNormalizedString method to match the IPv6 one. I'd imagine it just is the same as toString, i.e.

ipaddr.IPv4.prototype.toNormalizedString = ipaddr.IPv4.prototype.toString;
@JamesMGreene JamesMGreene mentioned this issue Aug 19, 2017
Merged
@JamesMGreene
Copy link
Contributor Author

Submitted PR #71.

@JamesMGreene
Copy link
Contributor Author

P.S. I'm fine if you don't agree with this one.

@whitequark
Copy link
Owner

This one seems fine.

whitequark pushed a commit that referenced this issue Aug 20, 2017
@JamesMGreene @whitequark
Add IPv4.prototype.toNormalizedString for symmetry with the IPv6 me…
c2bcc6f 
…thod

Fixes #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @JamesMGreene