Add IPv4.prototype.toNormalizedString for symmetry with the IPv6 me…

…thod Fixes #67
whitequark · Aug 20, 2017 · c2bcc6f · c2bcc6f
1 parent 83174a9
commit c2bcc6f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 1 deletion.
diff --git a/ipaddr.min.js b/ipaddr.min.js
diff --git a/lib/ipaddr.js b/lib/ipaddr.js
@@ -76,6 +76,10 @@
       return this.octets.join(".");
     };
 
+    IPv4.prototype.toNormalizedString = function() {
+      return this.toString();
+    };
+
     IPv4.prototype.toByteArray = function() {
       return this.octets.slice(0);
     };

diff --git a/src/ipaddr.coffee b/src/ipaddr.coffee
@@ -66,6 +66,10 @@ class ipaddr.IPv4
   toString: ->
     return @octets.join "."
 
+  # Symmetrical method strictly for aligning with the IPv6 methods.
+  toNormalizedString: ->
+    return this.toString()
+
   # Returns an array of byte-sized values in network order (MSB first)
   toByteArray: ->
     return @octets.slice(0) # octets.clone

diff --git a/test/ipaddr.test.coffee b/test/ipaddr.test.coffee
@@ -21,6 +21,7 @@ module.exports =
   'converts IPv4 to string correctly': (test) ->
     addr = new ipaddr.IPv4([192, 168, 1, 1])
     test.equal(addr.toString(), '192.168.1.1')
+    test.equal(addr.toNormalizedString(), '192.168.1.1')
     test.done()
 
   'returns correct kind for IPv4': (test) ->