Add async_iterable support #720

Ms2ger · 2019-05-01T14:16:54Z

Fixes #580.

domenic

High-level comments as I skim through this between meetings. Will do more later.

domenic · 2019-05-01T18:51:57Z

index.bs

@@ -4091,6 +4104,138 @@ The following extended attributes are applicable to [=iterable declarations=]:
 </pre>


+<h4 id="idl-async-iterable">Asynchronously iterable declarations</h4>


Nit: I've never seen it spelled out as "asynchronously iterable". Maybe an "asynchronous iterable", as in the title of https://github.com/tc39/proposal-async-iteration. But "async iterable" is much more common.

index.bs

domenic

Overall LGTM! A few clarity suggestions.

index.bs

bzbarsky · 2019-05-21T18:55:34Z

This could probably use review from other implementors before it merges....

domenic · 2019-06-19T07:59:13Z

@bzbarsky would you have time to review this soon? I am planning to land WICG/kv-storage#68 with a reference to this pull request, but it would be even better if I could reference the base spec.

bzbarsky · 2019-06-19T20:32:59Z

This week is a Mozilla all-hands, so my time is very unpredictable through Friday. I can make this a priority on Monday, though. Is that good enough?

domenic · 2019-06-19T23:57:28Z

That would be great, thank you!

ricea · 2019-06-25T14:48:36Z

I have some concerns about how we will apply this to the Streams standard. The iterable definition has this text:

If a single type parameter is given, then the interface has a value iterator and provides values of the specified type

but async_iterable lacks a similar provision. Since a ReadableStream has no keys, this makes application of the standard text difficult. There's nothing meaningful that a keys() method could iterate over, and I don't know how values() would be different from entries().

Ms2ger · 2019-06-25T15:26:56Z

I've got a WIP for value-only iterators in https://github.com/heycam/webidl/compare/async-iterator-values?expand=1.

index.bs

bzbarsky · 2019-06-25T18:40:21Z

index.bs

+1.  a value of the second type given in the declaration;
+1.  an opaque value that is passed back to the next invocation of the algorithm,
+
+The prose may also define <dfn>asynchronous iterator initialization steps</dfn> for the


What are these steps allowed to do? This seems pretty open-ended... Maybe that's ok.

This is supposed to be a step towards handling https://streams.spec.whatwg.org/#rs-get-iterator ; not sure if it's necessary to restrict anything here.

Are we OK with the steps here calling into arbitrary script, say? (We might be; I haven't audited very carefully.)

bzbarsky · 2019-06-25T18:44:17Z

index.bs

+
+<pre class="grammar" id="prod-AsyncIterable">
+    AsyncIterable :
+        "async_iterable" "&lt;" TypeWithExtendedAttributes "," TypeWithExtendedAttributes "&gt;" ";"


Is there a reason for async_iterable rather than async iterable? The latter seems a bit nicer to read/write to me and the grammar bit should be fine, I expect.

No strong feelings from my side on this.

I would personally prefer async iterable.

index.bs

Ms2ger · 2019-06-26T11:25:06Z

Thanks for the review; I think I covered most of the issues.

bzbarsky · 2019-06-27T23:02:36Z

Generally looks good, thanks! I think I would still prefer async iterator without the underscore.

ricea · 2019-06-28T10:17:16Z

Generally looks good, thanks! I think I would still prefer async iterator without the underscore.

@yuki3 Would async iterator as two tokens cause problems for Blink's IDL parser?

yuki3 · 2019-06-28T10:39:50Z

I think that it should be just fine. We already have "partial dictionary", "partial interface", "callback interface", etc. I don't think that a space between "async" and "iterator" will be a problem.

domenic

Shall we merge?

inexorabletash · 2019-07-15T20:26:54Z

What's the support in bikeshed and WPT's respective IDL parsers?

marcoscaceres · 2019-07-15T23:09:05Z

For WTP, I don't think we support this yet in WebIDL2.js, right @saschanaz? Would be trivial to add tho.

saschanaz · 2019-07-15T23:10:09Z

@marcoscaceres Right, we don't. I can cook a PR soon.

saschanaz · 2019-07-15T23:11:35Z

Just to make sure: async_iterable or async iterable?

marcoscaceres · 2019-07-15T23:11:58Z

"async iterable" by looking at the example.

marcoscaceres · 2019-07-16T02:08:41Z

Ok, @saschanaz added support (w3c/webidl2.js#365). We will wait for this to merge. Probably want to bugs filed on browser engines too.

Fixes #580.

domenic mentioned this pull request May 1, 2019

Async iterables are happening WICG/file-system-access#47

Closed

domenic reviewed May 1, 2019

View reviewed changes

domenic mentioned this pull request May 7, 2019

Define Web IDL Modules #675

Closed

Ms2ger mentioned this pull request May 15, 2019

Use Web IDL to define the API WICG/kv-storage#68

Merged

domenic reviewed May 21, 2019

View reviewed changes

index.bs Outdated Show resolved Hide resolved

index.bs Show resolved Hide resolved

index.bs Outdated Show resolved Hide resolved

index.bs Show resolved Hide resolved

index.bs Outdated Show resolved Hide resolved

index.bs Outdated Show resolved Hide resolved

Ms2ger force-pushed the async-iterator branch from b805927 to 9393044 Compare May 23, 2019 12:20

ricea mentioned this pull request Jun 10, 2019

Switching to Web IDL whatwg/streams#963

Closed

This was referenced Jun 24, 2019

Inconsistent enumerability on keys/values/entries and friends #738

Closed

Should iterator prototype object next functions be enumerable? #739

Open

bzbarsky reviewed Jun 25, 2019

View reviewed changes

Ms2ger force-pushed the async-iterator branch from e1d4a24 to 284039d Compare June 26, 2019 11:21

Ms2ger force-pushed the async-iterator branch from 284039d to 490f708 Compare June 26, 2019 11:36

domenic approved these changes Jul 15, 2019

View reviewed changes

saschanaz mentioned this pull request Jul 15, 2019

feat: support async iterable<> w3c/webidl2.js#365

Merged

Ms2ger added 3 commits August 7, 2019 12:18

Editorial: Split out an 'iterator result' algorithm.

36de46d

Formalize value pairs.

c026375

Add async_iterable support

6ac2d3d

Fixes #580.

Ms2ger force-pushed the async-iterator branch from d9f4ce2 to 6ac2d3d Compare August 7, 2019 10:18

Ms2ger merged commit d6caf50 into master Aug 7, 2019

Ms2ger deleted the async-iterator branch August 7, 2019 10:29

domenic mentioned this pull request Aug 7, 2019

Add support for async_iterable syntax plinss/widlparser#41

Closed

saschanaz mentioned this pull request Aug 11, 2019

Should async be allowed as an attribute name? #768

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add async_iterable support #720

Add async_iterable support #720

Ms2ger commented May 1, 2019 •

edited by pr-preview bot

Loading

domenic left a comment

domenic May 1, 2019

domenic left a comment

bzbarsky commented May 21, 2019

domenic commented Jun 19, 2019

bzbarsky commented Jun 19, 2019

domenic commented Jun 19, 2019

ricea commented Jun 25, 2019

Ms2ger commented Jun 25, 2019

bzbarsky Jun 25, 2019

Ms2ger Jun 26, 2019

bzbarsky Jun 26, 2019

bzbarsky Jun 25, 2019

Ms2ger Jun 26, 2019

bzbarsky Jun 27, 2019

Ms2ger commented Jun 26, 2019

bzbarsky commented Jun 27, 2019

ricea commented Jun 28, 2019

yuki3 commented Jun 28, 2019

domenic left a comment

inexorabletash commented Jul 15, 2019

marcoscaceres commented Jul 15, 2019

saschanaz commented Jul 15, 2019

saschanaz commented Jul 15, 2019

marcoscaceres commented Jul 15, 2019

marcoscaceres commented Jul 16, 2019

		@@ -4091,6 +4104,138 @@ The following extended attributes are applicable to [=iterable declarations=]:
		</pre>


		<h4 id="idl-async-iterable">Asynchronously iterable declarations</h4>

Add async_iterable support #720

Add async_iterable support #720

Conversation

Ms2ger commented May 1, 2019 • edited by pr-preview bot Loading

domenic left a comment

Choose a reason for hiding this comment

domenic May 1, 2019

Choose a reason for hiding this comment

domenic left a comment

Choose a reason for hiding this comment

bzbarsky commented May 21, 2019

domenic commented Jun 19, 2019

bzbarsky commented Jun 19, 2019

domenic commented Jun 19, 2019

ricea commented Jun 25, 2019

Ms2ger commented Jun 25, 2019

bzbarsky Jun 25, 2019

Choose a reason for hiding this comment

Ms2ger Jun 26, 2019

Choose a reason for hiding this comment

bzbarsky Jun 26, 2019

Choose a reason for hiding this comment

bzbarsky Jun 25, 2019

Choose a reason for hiding this comment

Ms2ger Jun 26, 2019

Choose a reason for hiding this comment

bzbarsky Jun 27, 2019

Choose a reason for hiding this comment

Ms2ger commented Jun 26, 2019

bzbarsky commented Jun 27, 2019

ricea commented Jun 28, 2019

yuki3 commented Jun 28, 2019

domenic left a comment

Choose a reason for hiding this comment

inexorabletash commented Jul 15, 2019

marcoscaceres commented Jul 15, 2019

saschanaz commented Jul 15, 2019

saschanaz commented Jul 15, 2019

marcoscaceres commented Jul 15, 2019

marcoscaceres commented Jul 16, 2019

Ms2ger commented May 1, 2019 •

edited by pr-preview bot

Loading